Update ERC-4337: Extract aggregation to a separate ERC #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dror Tirosh <dror.tirosh@gmail.com>
Co-authored-by: Dror Tirosh <dror.tirosh@gmail.com>
Co-authored-by: Dror Tirosh <dror.tirosh@gmail.com>
|
✅ All reviewers have approved. |
eip-review-bot
changed the title
shahafn
reviewed
Sep 10, 2024
ERCS/erc-4337.md
Outdated
| SHOULD return SIG_VALIDATION_FAILED (and not revert) on signature mismatch. Any other error MUST revert. | ||
| * MUST pay the entryPoint (caller) at least the "missingAccountFunds" (which might be zero, in case the current account's deposit is high enough) | ||
| * The account MAY pay more than this minimum, to cover future transactions (it can always issue `withdrawTo` to retrieve it) | ||
| * The return value MUST be packed of `authorizer`, `validUntil` and `validAfter` timestamps. | ||
| * authorizer - 0 for valid signature, 1 to mark signature failure. Otherwise, an address of an authorizer contract. This ERC defines a "signature aggregator" as an authorizer. | ||
| * authorizer - 0 for valid signature, 1 to mark signature failure. Otherwise, an address of an authorizer contract, as defined in [ERC-XXXX](link). |
There was a problem hiding this comment.
Fixed. Waiting for ERC-7766 to be merged.
shahafn
reviewed
Sep 10, 2024
ERCS/erc-4337.md
Outdated
| ``` | ||
|
|
||
| The `AggregatorStakeInfo` structure is further defined in [ERC-XXXX](link). |
There was a problem hiding this comment.
Fixed. Waiting for ERC-7766 to be merged.
eip-review-bot
approved these changes
Sep 18, 2024
eip-review-bot
approved these changes
Sep 18, 2024
eip-review-bot
approved these changes
Sep 19, 2024
|
The commit c4a2dfe (as a parent of 5b627c0) contains errors. |
|
Close then reopen this after the other PR is merged and this one will go through. |
eip-review-bot
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: