Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-3668: fix typo in erc3668 lookup process #656

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Update ERC-3668: fix typo in erc3668 lookup process #656

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1678d55
fix typo in erc3668 lookup process
0xc0de4c0ffee Sep 27, 2024
81d1693
Update erc-3668.md
SamWilsn Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ERCS/erc-3668.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
eip: 3668
title: "CCIP Read: Secure offchain data retrieval"

Check failure on line 3 in ERCS/erc-3668.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `title` should not contain `:` 

error[preamble-re-title-colon]: preamble header `title` should not contain `:`
 --> ERCS/erc-3668.md:3:7
  |
3 | title: "CCIP Read: Secure offchain data retrieval"
  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ prohibited pattern was matched
  |
  = info: the pattern in question: `:`
  = help: see https://ethereum.github.io/eipw/preamble-re-title-colon/

Check failure on line 3 in ERCS/erc-3668.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `title` should not contain `:` 

error[preamble-re-title-colon]: preamble header `title` should not contain `:`
 --> ERCS/erc-3668.md:3:7
  |
3 | title: "CCIP Read: Secure offchain data retrieval"
  |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ prohibited pattern was matched
  |
  = info: the pattern in question: `:`
  = help: see https://ethereum.github.io/eipw/preamble-re-title-colon/
description: CCIP Read provides a mechanism to allow a contract to fetch external data.
author: Nick Johnson (@arachnid)
discussions-to: https://ethereum-magicians.org/t/durin-secure-offchain-data-retrieval/6728
Expand Down Expand Up @@ -295,8 +295,8 @@
5. If the `sender` field does not match the address of the contract that was called, return an error to the caller and stop.
6. Construct a request URL by replacing `sender` with the lowercase 0x-prefixed hexadecimal formatted `sender` parameter, and replacing `data` with the 0x-prefixed hexadecimal formatted `callData` parameter. The client may choose which URLs to try in which order, but SHOULD prioritise URLs earlier in the list over those later in the list.
7. Make an HTTP GET request to the request URL.
8. If the response code from step (5) is in the range 400-499, return an error to the caller and stop.
9. If the response code from step (5) is in the range 500-599, go back to step (5) and pick a different URL, or stop if there are no further URLs to try.
8. If the response code from step (7) is in the range 400-499, return an error to the caller and stop.
9. If the response code from step (7) is in the range 500-599, go back to step (5) and pick a different URL, or stop if there are no further URLs to try.
10. Otherwise, replace `data` with an ABI-encoded call to the contract function specified by the 4-byte selector `callbackFunction`, supplying the data returned from step (7) and `extraData` from step (4), and return to step (1).

Clients MUST handle HTTP status codes appropriately, employing best practices for error reporting and retries.
Expand Down
Loading