Add ERC: Interoperable Delegated Accounts #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All reviewers have approved. |
eip-review-bot
changed the title
PowerStream3604
force-pushed
the
add-erc-interoperable-delegated-account
branch
from
372e22a to
c66616e
Compare
PowerStream3604
force-pushed
the
add-erc-interoperable-delegated-account
branch
from
c66616e to
d9dd8db
Compare
abcoathup
reviewed
Oct 1, 2024
abcoathup
reviewed
Oct 1, 2024
58 tasks
SamWilsn
reviewed
Oct 29, 2024
eip-review-bot
changed the title
|
@SamWilsn could you review this PR again? Thank you |
|
The commit a907688 (as a parent of c79a9e9) contains errors. |
30 tasks
11 tasks
15 tasks
SamWilsn
reviewed
Dec 9, 2024
SamWilsn
approved these changes
Dec 9, 2024
eip-review-bot
approved these changes
Dec 9, 2024
eip-review-bot
approved these changes
Dec 9, 2024
eip-review-bot
approved these changes
Dec 9, 2024
filmakarov
reviewed
Dec 18, 2024
|
|
||
| However, there is a need to help facilitate storage management for redelegation, as invalid management of storage may incur storage collisions that can lead to unexpected behavior of accounts (e.g., account getting locked, security vulnerabilities, etc) | ||
|
|
||
| The interface `InteroperableDelegatedAccount` suggests the interfaces for delegated EOAs to be interoperable and facilitate a better environment for redelegation. |
There was a problem hiding this comment.
The interface
InteroperableDelegatedAccountsuggests the interfaces
I would change the second occurrence of 'interface' with 'methods' or 'functions'
filmakarov
reviewed
Dec 18, 2024
|
|
||
| `onRedelegation()` was designed to be optional to lower the barrier of being compliant with this standard. Also, there could be accounts that does not functionally require a hook-logic to be in place before redelegation, or accounts that does not suite with the design principle of the `onRedelegation()` e.g., excessive use of mapping or data types that's hard to uninitialize. | ||
|
|
||
| It is worth noting that, `onRedelegation()` does not obligate the account to completely whipe out it's storage. It's more of a best effort function to leave the cleanest stage for the future use of the EOA in a new wallet. Or to execute a function to prepare for redelegation. |
There was a problem hiding this comment.
typo in ' ... whipe out ...'
filmakarov
reviewed
Dec 18, 2024
|
|
||
| Also, the account should make sure the initializer cannot be triggered by an arbitrary entity after `onRedelegation()` is called. | ||
|
|
||
| 4. `onRedelegation()` should not reset the replay protection considering that it could incur a vulnerability(e.g., signature reply attack). |
There was a problem hiding this comment.
typo in 'signature reply attack'
|
Have you guys considered accepting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal outlines the interfaces and behavior for delegated accounts, for better interoperability and storage management.