Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Soulbound Degradable Governance #674

Merged
merged 15 commits into from
Dec 10, 2024

Conversation

0xneves
Copy link
Contributor

@0xneves 0xneves commented Oct 14, 2024

This proposal introduces the Soulbound Degradable Governance (SDG), offering a unique solution to common governance challenges in early-stage DAOs by addressing the imbalance between economic and political power, splitting the two forces into two separate tokens.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 14, 2024

✅ All reviewers have approved.

ERCS/erc-TBA.md Outdated Show resolved Hide resolved
ERCS/erc-TBA.md Outdated Show resolved Hide resolved
ERCS/erc-TBA.md Outdated Show resolved Hide resolved
0xneves and others added 2 commits October 16, 2024 00:32
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@github-actions github-actions bot removed the w-ci label Oct 16, 2024
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@github-actions github-actions bot added the w-ci label Oct 16, 2024
@github-actions github-actions bot removed the w-ci label Oct 16, 2024
@0xneves
Copy link
Contributor Author

0xneves commented Oct 16, 2024

Getting a lot of errors from EIP Walidator after changing file name 🤔

ERCS/erc-7787.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the w-ci label Oct 16, 2024
@github-actions github-actions bot removed the w-ci label Oct 16, 2024
Copy link

The commit d6a4e63 (as a parent of cf9917f) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Oct 16, 2024
@github-actions github-actions bot removed the w-ci label Oct 16, 2024
ERCS/erc-7787.md Outdated Show resolved Hide resolved
ERCS/erc-7787.md Show resolved Hide resolved
ERCS/erc-7787.md Outdated Show resolved Hide resolved
ERCS/erc-7787.md Outdated Show resolved Hide resolved
ERCS/erc-7787.md Outdated Show resolved Hide resolved
ERCS/erc-7787.md Outdated Show resolved Hide resolved
ERCS/erc-7787.md Outdated Show resolved Hide resolved
ERCS/erc-7787.md Outdated Show resolved Hide resolved
ERCS/erc-7787.md Outdated Show resolved Hide resolved
SamWilsn
SamWilsn previously approved these changes Dec 10, 2024
Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for a Draft, but do think about the points I'm raising here.


The implementer of this standard MUST:

1. Override the `transfer(...)` function for the governance token to block transfers between addresses.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear whether the "governance token" here refers to the "political power" token or the "economic power" token. I'd guess that it's political, but it's better to be clear.

*/
function getVotes(address account) public view virtual returns (uint256);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

ERCS/erc-7787.md Outdated Show resolved Hide resolved
@eip-review-bot eip-review-bot enabled auto-merge (squash) December 10, 2024 16:29
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 4898ab1 into ethereum:master Dec 10, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants