-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Soulbound Degradable Governance #674
Conversation
✅ All reviewers have approved. |
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Getting a lot of errors from EIP Walidator after changing file name 🤔 |
The commit d6a4e63 (as a parent of cf9917f) contains errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for a Draft, but do think about the points I'm raising here.
|
||
The implementer of this standard MUST: | ||
|
||
1. Override the `transfer(...)` function for the governance token to block transfers between addresses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unclear whether the "governance token" here refers to the "political power" token or the "economic power" token. I'd guess that it's political, but it's better to be clear.
*/ | ||
function getVotes(address account) public view virtual returns (uint256); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
This proposal introduces the Soulbound Degradable Governance (SDG), offering a unique solution to common governance challenges in early-stage DAOs by addressing the imbalance between economic and political power, splitting the two forces into two separate tokens.