Add ERC-7798: Tap to Pay #686

amhed · 2024-10-26T01:51:26Z

See https://hackmd.io/VyxIMlk1SvCOpBpS6a_2uA?both for initial commentary on the standard

eip-review-bot · 2024-10-26T01:51:53Z

File `ERCS/erc-7798.md`

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

ERCS/erc-_____.md

wilsoncusack · 2024-10-26T11:27:32Z

ERCS/erc-_____.md

+1. The merchant is running an app on their point-of-sale (PoS) system that allows initiating a checkout flow. 
+1. When the customer is done ordering, the merchant goes through the checkout flow up and triggers a payment request. 
+1. The merchant app calls the `requestContactlessPayment` RPC method with the expected payload. 
+1. The merchant's device emits an NFC signal via host card emulation ([HCE](https://developer.android.com/develop/connectivity/nfc/hce)) for the customer’s device to read.


Is this done via the Ethereum provider receiving the above call? So is it assumed the provider needs to be running on device?

wilsoncusack · 2024-10-26T11:28:26Z

ERCS/erc-_____.md

+1. When the customer is done ordering, the merchant goes through the checkout flow up and triggers a payment request. 
+1. The merchant app calls the `requestContactlessPayment` RPC method with the expected payload. 
+1. The merchant's device emits an NFC signal via host card emulation ([HCE](https://developer.android.com/develop/connectivity/nfc/hce)) for the customer’s device to read.
+1. The customer, running their wallet software of choice, reads the NFC signal. The customer’s wallet constructs the necessary transaction(s) to execute the onchain checkout. 


Sorry I don't know much about this, why couldn't we just do a normal eth_sendTransaction or wallet_sendCalls via an NFC channel?

We had some sluggish performance transmitting the NFC message with larger payloads and decided to use a relayer for a shorter URI.

you could still use a relayer by using wallet_sendCalls + something like a nfcRelay capability

wilsoncusack · 2024-10-26T11:29:23Z

ERCS/erc-_____.md

+1. Upon successful onchain execution of these transactions, the checkout is complete.
+
+#### Use Case 2: Peer-to-peer Sends
+1. Alice requests a payment on her wallet app by emitting an NFC signal. The contents of the signal is an EIP-681 URI


I think 681 is possibly over specified on things like gas values. Wonder if we could align on something more minimal.

We're already using 681 heavily on send/receive flows on CB Wallet. We tried leaning into existing standards. What would you suggest could be better?

wilsoncusack · 2024-10-26T11:30:39Z

ERCS/erc-_____.md

+    - 1 means the URI is an EIP-681-compliant payload.
+    - 2 means the URI points to an HTTP relayer, where the response of the relayer is either a JSON object with the transaction data already encoded as a 0x string, or a message for the customer to sign. The customer wallet is responsible for constructing, signing and submitting the transaction/message.
+
+- `uri` represents either the EIP-681-compliant payload or the relayer endpoint to query for the JSON payload. 


I feel like 681 URI is not widely adopted and is mostly useful when you can share a string with someone and not a whole payload.

But here we control the channel so I'm again wondering why not just use existing wallet RPCs to describe what we want.

You're right, it's not widely adopted. Open to any other suggestions 🙏

amhed · 2024-10-26T14:43:40Z

Thanks for the quick review @wilsoncusack ❤️

ERCS/erc-_____.md

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>

ERCS/erc-_____.md

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>

amhed · 2024-10-29T18:10:50Z

ERCS/erc-7798.md

+```
+
+##### EIP-712
+```ts


I don't think 712 is available on this repository. What's the proper way to do a relative ref here?

- Some fixes on automated PR feedback - Remove relative links - Adds copyright waiver

lukasrosario · 2024-10-30T12:26:22Z

ERCS/erc-7798.md

+});
+```
+
+### Type 1


are offchain signatures supported for type 1? i dont think it's covered by 681?

No, we covered them with the relayed URI. You can basically pass down any long-form payload / set of batched transactions for EIP-3009 or permit2

lukasrosario · 2024-10-30T12:26:42Z

ERCS/erc-7798.md

+}
+```
+
+**[EIP-712](https://eips.ethereum.org/EIPS/eip-712) Message (offline signature)**


hm i guess sendCalls wouldnt work for getting offchain signatures

lukasrosario · 2024-10-30T14:20:35Z

overall i agree with Wilson's feedback -- feel like it would be cleanest if we could just transmit the usual RPC request over the NFC channel. would be easier for devs to reason about and i think it would be easier to adopt than extending the 1193 provider.

seems like there were issues transmitting larger messages through nfc, and it makes me wonder if that should just be an issue for the provider to resolve if the message is to be transmitted over NFC. that way the app dev can use the same interface as usual, and then the wallet maintainers resolve how to compress & transmit to wallet.

amhed · 2024-10-30T15:52:15Z

seems like there were issues transmitting larger messages through nfc, and it makes me wonder if that should just be an issue for the provider to resolve if the message is to be transmitted over NFC. that way the app dev can use the same interface as usual, and then the wallet maintainers resolve how to compress & transmit to wallet.

When you mention the same interface you mend wallet_sendCalls? And send URIs instead of hashed strings representing txs?

github-actions · 2024-11-05T13:41:30Z

The commit b0b33c8 (as a parent of 097acbf) contains errors.
Please inspect the Run Summary for details.

lukasrosario · 2024-11-05T16:02:50Z

When you mention the same interface you mend wallet_sendCalls?
correct

And send URIs instead of hashed strings representing txs?
i dont have as strong of an opinion on how the transaction payloads themselves are structured. in fact, if we keep the developer interface the same and just use a 5792 capability, for example, then we don't even need to impose any kind of constraint on the transaction payload format and can let the provider choose the format as they wish. i suppose the problem then becomes you lose the ability to do offchain signatures. i wonder how much of an issue that would be though

amhedcb added 2 commits October 25, 2024 21:48

First draft of ERC-7762

2a53c86

no direct assignment

96d6ac6

amhed requested a review from eip-review-bot as a code owner October 26, 2024 01:51

github-actions bot added c-new s-draft t-erc labels Oct 26, 2024

eip-review-bot added e-consensus e-review labels Oct 26, 2024

eip-review-bot changed the title ~~ERC Proposal: Tap to pay open standard~~ Add ERC: Contactless Crypto Payment Standard Oct 26, 2024

github-actions bot added the w-ci label Oct 26, 2024

wilsoncusack reviewed Oct 26, 2024

View reviewed changes

abcoathup reviewed Oct 28, 2024

View reviewed changes

ERCS/erc-_____.md Outdated Show resolved Hide resolved

abcoathup reviewed Oct 28, 2024

View reviewed changes

ERCS/erc-_____.md Outdated Show resolved Hide resolved

abcoathup reviewed Oct 28, 2024

View reviewed changes

ERCS/erc-_____.md Outdated Show resolved Hide resolved

Title Update

98f6b9d

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>

eip-review-bot changed the title ~~Add ERC: Contactless Crypto Payment Standard~~ Add ERC: Contactless Payment Oct 28, 2024

Adds authors

1d625b6

abcoathup reviewed Oct 29, 2024

View reviewed changes

ERCS/erc-_____.md Outdated Show resolved Hide resolved

EIP has a number

c498382

Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>

github-actions bot added w-ci and removed w-ci labels Oct 29, 2024

amhed commented Oct 29, 2024

View reviewed changes

github-actions bot removed the w-ci label Oct 29, 2024

Rename file to ERC-7798.md

1374d1a

- Some fixes on automated PR feedback - Remove relative links - Adds copyright waiver

amhed force-pushed the erc-taptopay branch from 4186dbc to 1374d1a Compare October 29, 2024 18:15

rename to tap to pay

768b114

eip-review-bot changed the title ~~Add ERC: Contactless Payment~~ Add ERC: Tap to Pay Oct 29, 2024

EIP-712 external link

bcc7b4c

github-actions bot added the w-ci label Oct 29, 2024

Adds a sequence diagram

62a5e7e

amhed changed the title ~~Add ERC: Tap to Pay~~ ERC-7798: Tap to Pay Oct 29, 2024

github-actions bot added w-ci and removed w-ci labels Oct 29, 2024

eip-review-bot changed the title ~~ERC-7798: Tap to Pay~~ Add ERC: Tap to Pay Oct 30, 2024

lukasrosario reviewed Oct 30, 2024

View reviewed changes

Removing sample code

b0b33c8

amhed changed the title ~~Add ERC: Tap to Pay~~ Add ERC-7798]: Tap to Pay Nov 5, 2024

amhed changed the title ~~Add ERC-7798]: Tap to Pay~~ Add ERC-7798: Tap to Pay Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ERC-7798: Tap to Pay #686

Add ERC-7798: Tap to Pay #686

amhed commented Oct 26, 2024 •

edited

Loading

eip-review-bot commented Oct 26, 2024 •

edited

Loading

wilsoncusack Oct 26, 2024

amhed Oct 26, 2024

wilsoncusack Oct 26, 2024

amhed Oct 26, 2024

lukasrosario Oct 30, 2024

wilsoncusack Oct 26, 2024

amhed Oct 26, 2024

wilsoncusack Oct 26, 2024

amhed Oct 26, 2024

amhed commented Oct 26, 2024

amhed Oct 29, 2024

lukasrosario Oct 30, 2024

amhed Oct 30, 2024

lukasrosario Oct 30, 2024

lukasrosario commented Oct 30, 2024

amhed commented Oct 30, 2024

github-actions bot commented Nov 5, 2024

lukasrosario commented Nov 5, 2024

Add ERC-7798: Tap to Pay #686

Are you sure you want to change the base?

Add ERC-7798: Tap to Pay #686

Conversation

amhed commented Oct 26, 2024 • edited Loading

eip-review-bot commented Oct 26, 2024 • edited Loading

File ERCS/erc-7798.md

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amhed commented Oct 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lukasrosario commented Oct 30, 2024

amhed commented Oct 30, 2024

github-actions bot commented Nov 5, 2024

lukasrosario commented Nov 5, 2024

amhed commented Oct 26, 2024 •

edited

Loading

eip-review-bot commented Oct 26, 2024 •

edited

Loading

File `ERCS/erc-7798.md`