RIP 7696 : provide asset code #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RIPS/rip-7696.md
Outdated
|
|
||
| 3. **bn254-G1 :** Zcash, Tornado Cash, as specified by EIP1962. | ||
|
|
||
| 4. **Jujub :** Circom proving system compatibility. |
There was a problem hiding this comment.
nit: JubJub
Also would clarify baby-Jubjub or change explanation text, the original JubJub on BLS12-381 is not really used with Circom
There was a problem hiding this comment.
CarlBeek
approved these changes
Oct 7, 2024
CarlBeek
requested changes
Oct 7, 2024
There was a problem hiding this comment.
@rdubois-crypto Please resolve conflicts with existing files.
Additionally, we can't accept copyrighted code to this repo, finally the assets shouldn't include tests in a separate file, to my knowledge this is not how we run EIPs/ERCs
|
How shall the vectors appear then ? Code shall be tested in some way. Concerning the copyright, it is MIT (the SPDX identifier is present in files), so this is open source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided codes demonstrate the use of the precompile to implement ECDSA over P256.
Curves parameters are provided as parameters instead of constant. ecPow128 computes the value 2^128.P, 2^128.Q required by the precompile.