This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Copy evmjit.dll to output on windows #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -409,10 +413,8 @@ if (JSCONSOLE) | |||
| add_subdirectory(ethconsole) | |||
| endif () | |||
|
|
|||
| if (NOT WIN32) | |||
| @@ -42,7 +42,7 @@ if (JSCONSOLE) | |||
| endif() | |||
|
|
|||
| if (DEFINED WIN32 AND NOT DEFINED CMAKE_COMPILER_IS_MINGW) | |||
| eth_copy_dlls("${EXECUTABLE}" MHD_DLLS) | |||
| eth_copy_dlls("${EXECUTABLE}" MHD_DLLS EVMJIT_DLLS) | |||
There was a problem hiding this comment.
MSVC isn't CMAKE_COMPILER_IS_MINGW :)
There was a problem hiding this comment.
@subtly, NOT DEFINED CMAKE_COMPILER_IS_MINGW there, so msvc fits.
There was a problem hiding this comment.
In other parts "compiler match msvc" is used. And it's just simpler.
|
Does eth need to be directly linked to evmjit? Or is evmjit header only? If it's the former... eth doesn't have any linkage to evmjit. What all needs to link evmjit? |
|
evmjit builds as dll on widows (unlike other libraries which build as static). Every executable that links it directly or indirectly needs the dll to run. This build action copies the dll to the exe output dir |
reverted libsecp256k1 changes
|
base? preferably on whizz branch. |
win-jit-dll Conflicts: eth/CMakeLists.txt
into win-jit-dll Conflicts: CMakeLists.txt
|
looksgood |
gavofyork
pushed a commit
that referenced
this pull request
Jul 20, 2015
Copy evmjit.dll to output on windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.