Skip to content
This repository was archived by the owner on Oct 28, 2021. It is now read-only.

add test_addTransaction #4924

Closed
wants to merge 1 commit into from
Closed

add test_addTransaction #4924

wants to merge 1 commit into from

Conversation

winsvega
Copy link
Contributor

test method that allows to import unsigned transactions with explicit private key field that will be used to sign it.

ethereum/retesteth#6

@winsvega winsvega requested review from axic and gumb0 March 29, 2018 13:19
@gumb0
Copy link
Member

gumb0 commented Mar 29, 2018

I don't quite like the name, there are eth_sendTransaction and eth_sendRawTransaction, how about test_signAndSendTransaction ?

@winsvega
Copy link
Contributor Author

the discussion is here
ethereum/retesteth#6

@codecov-io
Copy link

codecov-io commented Mar 29, 2018

Codecov Report

Merging #4924 into develop will increase coverage by 1.12%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4924      +/-   ##
===========================================
+ Coverage    59.43%   60.55%   +1.12%     
===========================================
  Files          347      349       +2     
  Lines        24255    28381    +4126     
  Branches      2791     2898     +107     
===========================================
+ Hits         14415    17187    +2772     
- Misses        8894    10216    +1322     
- Partials       946      978      +32

@winsvega
Copy link
Contributor Author

winsvega commented Apr 6, 2018

ok. I will implement transaction signing at retesteth side.

@winsvega winsvega closed this Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants