Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Activate Constantinople on Ropsten #5304

Merged
merged 2 commits into from
Oct 9, 2018
Merged

Activate Constantinople on Ropsten #5304

merged 2 commits into from
Oct 9, 2018

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Oct 8, 2018

Activating Constaninople at block 4'230'000

@gumb0 gumb0 requested a review from chfast October 8, 2018 11:02
@gumb0 gumb0 added this to the Constantinople milestone Oct 8, 2018
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests need update.

@gumb0
Copy link
Member Author

gumb0 commented Oct 8, 2018

Oh damn, that will require updating jsontests

@winsvega Would you help with updating https://github.com/ethereum/tests/blob/develop/BasicTests/difficultyRopsten.json ?

@winsvega winsvega force-pushed the ropsten-constantinople branch from 026b527 to 5f15267 Compare October 9, 2018 14:45
@winsvega
Copy link
Contributor

winsvega commented Oct 9, 2018

rebased on develop. point tests to: ethereum/tests#518

@winsvega winsvega force-pushed the ropsten-constantinople branch from 5f15267 to da587cb Compare October 9, 2018 15:11
@codecov-io
Copy link

Codecov Report

Merging #5304 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5304      +/-   ##
==========================================
+ Coverage   61.46%   61.46%   +<.01%     
==========================================
  Files         342      342              
  Lines       28044    28044              
  Branches     3234     3234              
==========================================
+ Hits        17236    17237       +1     
- Misses       9664     9666       +2     
+ Partials     1144     1141       -3

@gumb0
Copy link
Member Author

gumb0 commented Oct 9, 2018

@winsvega thanks

@chfast tests fixed now

@gumb0 gumb0 merged commit 645028b into master Oct 9, 2018
@gumb0 gumb0 deleted the ropsten-constantinople branch October 9, 2018 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants