Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Implement EIP-1884: Repricing for trie-size-dependent opcodes in aleth-interpreter #5725

Merged
merged 3 commits into from
Sep 2, 2019

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Aug 26, 2019

https://eips.ethereum.org/EIPS/eip-1884

It includes SELFBALANCE implementation; opcode repricing is enabled automagically via EVMC instruction metrics.

@gumb0 gumb0 force-pushed the eip-1884-interpreter branch from df947a7 to bc1090b Compare August 26, 2019 16:04
@codecov-io
Copy link

codecov-io commented Aug 26, 2019

Codecov Report

Merging #5725 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5725      +/-   ##
==========================================
+ Coverage   63.29%   63.34%   +0.05%     
==========================================
  Files         353      353              
  Lines       30321    30336      +15     
  Branches     3393     3394       +1     
==========================================
+ Hits        19191    19216      +25     
+ Misses       9895     9888       -7     
+ Partials     1235     1232       -3

@gumb0 gumb0 added this to the Istanbul milestone Aug 26, 2019
@gumb0 gumb0 mentioned this pull request Aug 26, 2019
18 tasks
@gumb0 gumb0 removed the in progress label Aug 26, 2019
@halfalicious
Copy link
Contributor

https://eips.ethereum.org/EIPS/eip-1884

It includes SELFBALANCE implementation; opcode repricing is enabled automagically via EVMC instruction metrics.

PR is currently based on LegacyVM implementation because of dependency on unit tests.

Where is the automagic opcode pricing done in EVMC?

@halfalicious
Copy link
Contributor

Is this ready for review? Looked at the feature changes and they look fine, still need to take a look at the tests.

@gumb0
Copy link
Member Author

gumb0 commented Sep 2, 2019

@halfalicious It will be ready after rebase

@gumb0 gumb0 force-pushed the eip-1884-interpreter branch from e518100 to a67c0ec Compare September 2, 2019 09:25
@gumb0
Copy link
Member Author

gumb0 commented Sep 2, 2019

@halfalicious instructions lib in EVMC provides costs for all opcodes on all revisions
https://github.com/ethereum/evmc/blob/master/include/evmc/instructions.h

@gumb0 gumb0 requested review from chfast and halfalicious September 2, 2019 09:28
@gumb0 gumb0 merged commit 25f5c3c into master Sep 2, 2019
@gumb0 gumb0 deleted the eip-1884-interpreter branch September 2, 2019 10:13
@halfalicious
Copy link
Contributor

@halfalicious instructions lib in EVMC provides costs for all opcodes on all revisions
https://github.com/ethereum/evmc/blob/master/include/evmc/instructions.h

@gumb0 Ah thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants