Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

fix testeth -t <TestSuite> -- --singletest <path> <testname> running a test from file #5750

Merged
merged 3 commits into from
Nov 6, 2019

Conversation

winsvega
Copy link
Contributor

@winsvega winsvega commented Sep 17, 2019

Closes #5743

Add support for testeth -t <TestSuite> -- --testfile <path>

@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #5750 into master will decrease coverage by 0.09%.
The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5750     +/-   ##
=========================================
- Coverage   64.12%   64.03%   -0.1%     
=========================================
  Files         360      359      -1     
  Lines       30866    30797     -69     
  Branches     3426     3416     -10     
=========================================
- Hits        19794    19722     -72     
- Misses       9845     9852      +7     
+ Partials     1227     1223      -4

@gumb0
Copy link
Member

gumb0 commented Oct 30, 2019

Rebased.

@gumb0 gumb0 mentioned this pull request Oct 30, 2019
6 tasks
@gumb0
Copy link
Member

gumb0 commented Nov 5, 2019

@winsvega please review my changes, hopefully I didn't break anything.

I removed Options::singleTest flag, now if singleTestName is non-empty it means --singletest is enabled.
And I changed optional<string> singleTestFile to just string, empty string means it was not set.

@gumb0 gumb0 merged commit ebf792d into master Nov 6, 2019
@gumb0 gumb0 deleted the testethfix branch November 6, 2019 19:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testeth feature request: run test without filler
5 participants