This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Get rid of precompile list in configs #5840
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
config-without-precompiles
branch
from
November 21, 2019 18:40
08d2b49
to
9841618
Compare
Codecov Report
@@ Coverage Diff @@
## master #5840 +/- ##
==========================================
+ Coverage 64.04% 64.06% +0.01%
==========================================
Files 362 362
Lines 30910 30896 -14
Branches 3434 3430 -4
==========================================
- Hits 19796 19793 -3
+ Misses 9885 9874 -11
Partials 1229 1229 |
gumb0
force-pushed
the
config-without-precompiles
branch
2 times, most recently
from
November 25, 2019 19:38
108eda9
to
5fae074
Compare
chfast
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 For removing registrar.
Move all constants for linear cost functions of precompiles into separate pricer definitions in Precompiled.cpp
But also don't consider it invalid yet.
gumb0
force-pushed
the
config-without-precompiles
branch
from
November 26, 2019 13:58
d082c06
to
52476e1
Compare
Rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5825
ChainOperationParams::precompiled
from config JSON, fill it with hard-coded list of 9 currently existing precompiles.PrecompiledContract
constructor changed to take precompile name string and starting block."precompile"
records in configs deprecated for now, so they will not generate validation error, but be ignored.We could also get rid of
PrecompiledRegistrar
at some point, I think it's a useless complication.cc @winsvega