This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Make RPC output same as Geth's for 2 RPC functions #5866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5866 +/- ##
=========================================
- Coverage 64.03% 64% -0.04%
=========================================
Files 364 364
Lines 30970 30970
Branches 3434 3434
=========================================
- Hits 19832 19822 -10
- Misses 9913 9921 +8
- Partials 1225 1227 +2 |
gumb0
reviewed
Dec 6, 2019
gumb0
reviewed
Dec 6, 2019
To check
or in Windows powershell
|
Make RPC output conform to Geth's output for debug_accountRange and eth_getTransactionCount.
halfalicious
force-pushed
the
rpc-output
branch
from
December 6, 2019 16:37
4f6f38e
to
16db2f8
Compare
Ah thanks for the tip, i haven't been able to get dopple.py working on Windows but will give it a shot on Linux. |
Unit tests need fixing |
Yup, there was a test which verified the string format. Fixed. |
cc @gumb0 |
gumb0
approved these changes
Dec 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5856
Make RPC output conform to Geth's output for
debug_accountRange
andeth_getTransactionCount
.