Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a separate session for every child process #15

Open
gsalgado opened this issue Apr 15, 2020 · 1 comment
Open

Consider using a separate session for every child process #15

gsalgado opened this issue Apr 15, 2020 · 1 comment

Comments

@gsalgado
Copy link
Contributor

gsalgado commented Apr 15, 2020

Currently, every process we start is on the same process group as the parent process, and that means a Ctrl-C in the terminal will cause a SIGINT to be sent to every process we start, but our parent process also has logic to detect a SIGINT and forward it to every child, so by default every child ends up receiving two SIGINTs, unless one adds a start_new_session=True item to open_in_process()s subprocess_kwargs` dict, like we do in trinity

As Piper suggested, though, we might want to have that as the default behaviour here

@pipermerriam
Copy link
Member

Can we even go as far as detecting this property of the child process and disabling the SIGINT behavior in the cases where the child process gets it automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants