Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on py38 as well #23

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Conversation

gsalgado
Copy link
Contributor

No description provided.

@gsalgado
Copy link
Contributor Author

Several tests seem to hang forever, but if you try to run them with -s --log-cli-level=debug they pass. I'm not looking forward to dig into that, so if anybody wants to have a go, be my guest ;-)

@gsalgado
Copy link
Contributor Author

gsalgado commented Jun 4, 2020

The hangs seem to have been caused by us hitting a race condition when we kill the process before it has had a chance to actually start executing -- a really short sleep before proc.send_signal() did the trick. A few tests fail randomly on py38, though -- I've left XXX comments on those. And one still hangs forever

@gsalgado
Copy link
Contributor Author

With #24 most tests are passing without the need for any changes -- there are only 3 tests that very rarely fail

@gsalgado
Copy link
Contributor Author

The tests failing randomly are not exclusive to py38 -- I can reproduce that in py37 as well, and filed #25 for that

@gsalgado
Copy link
Contributor Author

@pipermerriam I'm going ahead and merging this without waiting for a review as it doesn't include any changes to code/tests anymore

@gsalgado gsalgado merged commit 8ca3940 into ethereum:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant