Added withdrawals endpoint to fetch withdrawals from a parent state #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added into a new route, `/eth/v1/builder`, as it's different to the existing beacon state fetch paradigm, and a new Tag for builders seems appropriate. This endpoint is probably suited to allowing for returning SSZ via octet-stream also, so added that in. The idea would be similar to blocks, it would just return the data object as the SSZ result. It would be possible to add withdrawals_root, but it'd be at the same level as finalized, so it'd be a little less clean. I've left that out for now. Fixes ethereum#301.
michaelsproul
approved these changes
Feb 24, 2023
rkapka
approved these changes
Feb 24, 2023
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Aug 24, 2023
## Issue Addressed [#4029](#4029) ## Proposed Changes implement expected_withdrawals HTTP API per the spec ethereum/beacon-APIs#304 ## Additional Info
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Aug 24, 2023
## Issue Addressed [#4029](#4029) ## Proposed Changes implement expected_withdrawals HTTP API per the spec ethereum/beacon-APIs#304 ## Additional Info
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Aug 24, 2023
## Issue Addressed [#4029](#4029) ## Proposed Changes implement expected_withdrawals HTTP API per the spec ethereum/beacon-APIs#304 ## Additional Info
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
[sigp#4029](sigp#4029) implement expected_withdrawals HTTP API per the spec ethereum/beacon-APIs#304
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
[sigp#4029](sigp#4029) implement expected_withdrawals HTTP API per the spec ethereum/beacon-APIs#304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added into a new route,
/eth/v1/builder, as it's different to the existing beacon state fetch paradigm, and a new Tag for builders seems appropriate.This endpoint is probably suited to allowing for returning SSZ via octet-stream also, so added that in. The idea would be similar to blocks, it would just return the data object as the SSZ result.
It would be possible to add withdrawals_root, but it'd be at the same level as finalized, so it'd be a little less clean. I've left that out for now.
Fixes #301.