Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disambiguate and ensure consistency of proposeBlockV3/getBlockRewards consensus block value #481

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tersec
Copy link

@tersec tersec commented Oct 30, 2024

Implements the agreed-upon outcome of the discussion in that call.

@mcdee
Copy link
Contributor

mcdee commented Oct 31, 2024

I think that this remains unclear, specifically around if the value includes slashing rewards to the proposer or not.

@rolfyone
Copy link
Collaborator

I think that this remains unclear, specifically around if the value includes slashing rewards to the proposer or not.

part of proposer reward is explicitly the reward from inclusion of slashings, im not sure how we make it clearer unless we link to the spec...

@ensi321
Copy link
Contributor

ensi321 commented Oct 31, 2024

I think that this remains unclear, specifically around if the value includes slashing rewards to the proposer or not.

part of proposer reward is explicitly the reward from inclusion of slashings, im not sure how we make it clearer unless we link to the spec...

Agreed. Do we want to be explicit to the point saying Eth-Consensus-Block-Value = BlockRewards.total?

@mcdee
Copy link
Contributor

mcdee commented Nov 1, 2024

I think that stating explicitly that the rewards value is the sum of values the proposer rewards from attestations, sync committees and slashings included in the proposal would provide clarity on exactly what is and is not included.

@rolfyone
Copy link
Collaborator

@tersec if we can address @mcdee comment we can merge..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants