Use official trusted setup #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM on the java binding side. Can only delete |
|
It was brought to my attention that |
jangko
reviewed
Oct 18, 2023
flcl42
reviewed
Oct 18, 2023
realbigsean
reviewed
Oct 18, 2023
g11tech
approved these changes
Oct 18, 2023
|
I think we have approval from most client teams. Going to merge. |
This was referenced Oct 20, 2023
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Oct 20, 2023
## Issue Addressed Makes lighthouse compliant with new kzg changes in https://github.com/ethereum/consensus-specs/releases/tag/v1.4.0-beta.3 ## Proposed Changes 1. Adds new official trusted setup 2. Refactors kzg to match upstream changes in ethereum/c-kzg-4844#377 3. Updates pre-generated `BlobBundle` to work with official trusted setup. ~~Using json here instead of ssz to account for different value of `MaxBlobCommitmentsPerBlock` in minimal and mainnet. By using json, we can just use one pre generated bundle for both minimal and mainnet. Size of 2 separate ssz bundles is approximately equal to one json bundle cc @jimmygchen~~ Dunno what I was doing, ssz works without any issues 4. Stores trusted_setup as just bytes in eth2_network_config so that we don't have kzg dependency in that lib and in lcli. Co-authored-by: realbigsean <seananderson33@gmail.com> Co-authored-by: realbigsean <seananderson33@GMAIL.com>
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Oct 21, 2023
## Issue Addressed Makes lighthouse compliant with new kzg changes in https://github.com/ethereum/consensus-specs/releases/tag/v1.4.0-beta.3 ## Proposed Changes 1. Adds new official trusted setup 2. Refactors kzg to match upstream changes in ethereum/c-kzg-4844#377 3. Updates pre-generated `BlobBundle` to work with official trusted setup. ~~Using json here instead of ssz to account for different value of `MaxBlobCommitmentsPerBlock` in minimal and mainnet. By using json, we can just use one pre generated bundle for both minimal and mainnet. Size of 2 separate ssz bundles is approximately equal to one json bundle cc @jimmygchen~~ Dunno what I was doing, ssz works without any issues 4. Stores trusted_setup as just bytes in eth2_network_config so that we don't have kzg dependency in that lib and in lcli. Co-authored-by: realbigsean <seananderson33@gmail.com> Co-authored-by: realbigsean <seananderson33@GMAIL.com>
DaniPopes
added a commit
to DaniPopes/c-kzg-4844
that referenced
this pull request
Nov 11, 2023
Now that header definitions are stable across builds (ethereum#377), we can remove the Rust `bindgen` build dependency. This also transitively removes the dependency on `libclang`.
DaniPopes
added a commit
to DaniPopes/c-kzg-4844
that referenced
this pull request
Nov 11, 2023
Now that header definitions are stable across builds (ethereum#377), we can remove the Rust `bindgen` build dependency by gating it to an optional feature. This also transitively removes the dependency on `libclang` for Rust bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes in:
As an overview, this PR will:
FIELD_ELEMENTS_PER_BLOBvalue.