Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Only Snappy-Compressed Encoding #1931

Closed
rauljordan opened this issue Jun 24, 2020 · 4 comments
Closed

Allow Only Snappy-Compressed Encoding #1931

rauljordan opened this issue Jun 24, 2020 · 4 comments
Labels
general:discussion scope:networking
Milestone
v0.12.2

Comments

@rauljordan
Copy link
Contributor

rauljordan commented Jun 24, 2020 •
edited
Loading

Hi all,

Currently Prysm allows for both snappy compressed and regular ssz encoded messages via p2p. Our security audit concluded allowing these two options is a security risk that can result in a network partition of someone operates nodes without snappy and others operate nodes with snappy enabled. Is there still a need for non-snappy encoded messages in the networking spec, or should the spec enforce snappy-compressed only?
@protolambda
Copy link
Collaborator

We can discuss this during the implementers call today: ethereum/eth2.0-pm#162 (comment)

@djrtwo
Copy link
Contributor

djrtwo commented Jun 25, 2020

So we certainly shouldn't have non-snappy in gossip.
We have in currently in the req/resp which shouldn't be a security risk, but I don't see a particular use case for this

@prestonvanloon prestonvanloon mentioned this issue Jun 26, 2020
Merged
@djrtwo
Copy link
Contributor

djrtwo commented Jul 8, 2020

Thinking we remove this in the v0.12.2 release unless anyone is relying upon it and with good reason to continue to support

@djrtwo djrtwo added this to the v0.12.2 milestone Jul 22, 2020
@djrtwo djrtwo mentioned this issue Jul 23, 2020
Merged
@djrtwo
Copy link
Contributor

djrtwo commented Jul 23, 2020

closed via #1982

@djrtwo djrtwo closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
general:discussion scope:networking
Projects
None yet
Milestone
v0.12.2
Development

No branches or pull requests
3 participants
@djrtwo @rauljordan @protolambda