QSP-13 Only Allow Snappy P2P Encoding #6415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
changed the title
61 tasks
terencechain
previously approved these changes
Jun 26, 2020
|
Note: This is being discussed in the specs repo as well, but looks like this is the right direction. |
nisdas
reviewed
Jun 26, 2020
prestonvanloon
previously approved these changes
Jun 26, 2020
|
I think we should hold off on this until is final in the spec, it is still under discussion and hasnt been removed yet |
|
@nisdas in the eth2 call there was a discussion about this and teams agreed it is fine to remove. It is already removed from gossip in the spec and Danny has mentioned there is no other reason to keep it. The eth2 call was the chance for someone to speak up about it, but no one brought it up |
|
@rauljordan sounds good then, please fix conflicts here |
rauljordan
dismissed stale reviews from prestonvanloon and terencechain
via
c583ce8
Codecov Report
@@ Coverage Diff @@
## master #6415 +/- ##
==========================================
+ Coverage 60.07% 61.09% +1.02%
==========================================
Files 323 355 +32
Lines 27422 28811 +1389
==========================================
+ Hits 16473 17603 +1130
- Misses 8733 8849 +116
- Partials 2216 2359 +143 |
nisdas
previously approved these changes
Jun 30, 2020
0xKiwi
reviewed
Jul 1, 2020
| default: | ||
| panic("Invalid Network Encoding Flag Provided") | ||
| } | ||
| return &encoder.SszNetworkEncoder{} |
There was a problem hiding this comment.
Is UseSnappyCompression: true not needed here?
nisdas
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Currently, we allow for both snappy and non-snappy network encodings, which can lead to network partitions if someone has wrong configurations of their node or accidentally messes with the p2p encoding flags.
Which issues(s) does this PR fix?
Part of #6327