Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_genesis_beacon_state is not defined in the deposit contract #1075

Merged
merged 2 commits into from
May 12, 2019

Conversation

jrhea
Copy link
Contributor

@jrhea jrhea commented May 11, 2019

i modified the spec to link to the function.

get_genesis_beacon_state is not defined here.  i modified the spec to link to the function.
@jrhea
Copy link
Contributor Author

jrhea commented May 11, 2019

One problem with this is that it creates another maintenance point when doing a release. You have to change the link to point to the tagged version. Perhaps I should just mention that it is defined in: 0_beacon-chain.md

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched it to a relative path. Should be just fine

@djrtwo djrtwo changed the base branch from master to dev May 12, 2019 14:56
@djrtwo
Copy link
Contributor

djrtwo commented May 12, 2019

sending this to dev for now instead of master

@djrtwo djrtwo merged commit 9bd771f into ethereum:dev May 12, 2019
@jrhea jrhea deleted the patch-1 branch May 12, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants