Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a number of minor fixes in phase 1 #1120

Merged
merged 1 commit into from
May 25, 2019
Merged

a number of minor fixes in phase 1 #1120

merged 1 commit into from
May 25, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented May 24, 2019

There were some issues with variables and calls to structures.
Nothing substantive here.

CarlBeek
CarlBeek approved these changes May 25, 2019
View reviewed changes
Copy link
Contributor

@CarlBeek CarlBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍 Getting this merged will be beneficial for #1061 too

@djrtwo djrtwo merged commit dd09172 into dev May 25, 2019
@djrtwo djrtwo deleted the phase1-candidate-bug branch May 25, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlBeek CarlBeek CarlBeek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @CarlBeek