Bounce attack resistance #1465
Merged
Bounce attack resistance #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
suggested changes
Nov 5, 2019
specs/core/0_fork-choice.md
Outdated
|
|
||
| current_slot = get_current_slot(store) | ||
| # Not a new epoch, return | ||
| if not (current_slot > previous_slot and current_slot % SLOTS_PER_EPOCH == 0): |
protolambda
approved these changes
Nov 7, 2019
This was referenced Nov 8, 2019
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only allow updates to the latest justified for fork choice if within the first
SAFE_SLOTS_TO_UPDATE_JUSTIFIEDslots of an epoch or if the new justified does not conflict with the previous. If a new justified is learned about but doesn't satisfy these constraints, queue it up for consideration at next epoch boundary.This addresses the bouncing attack discussed here.
Testing justification and finalization in the fork choice is painful and needs to be reconsidered