Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.01 bit proof of custody [depends on 256 bit custody atoms] #1889

Merged
merged 7 commits into from
Jun 16, 2020

Conversation

dankrad
Copy link
Contributor

@dankrad dankrad commented Jun 12, 2020

@dankrad dankrad changed the title Dankrad custody 0.01bit [depends on 256 bit custody atoms] 0.01 bit proof of custody [depends on 256 bit custody atoms] Jun 12, 2020
@dankrad dankrad marked this pull request as ready for review June 13, 2020 14:16
@dankrad dankrad linked an issue Jun 15, 2020 that may be closed by this pull request
@djrtwo djrtwo mentioned this pull request Jun 15, 2020
16 tasks
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some minor cleanup. In general, this looks awesome.

I'd like to mask get_backing().get_left().merkle_root() into a spec helper with clear indication to implementers what's going on, but we can do that in the larger PR

specs/phase1/fork-choice.md Show resolved Hide resolved
specs/phase1/beacon-chain.md Show resolved Hide resolved
tests/core/pyspec/eth2spec/test/helpers/custody.py Outdated Show resolved Hide resolved
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

@djrtwo djrtwo merged commit eec323c into dankrad-custody-256bit Jun 16, 2020
@djrtwo djrtwo deleted the dankrad-custody-0.01bit branch June 16, 2020 13:20
@hwwhww hwwhww mentioned this pull request Jun 16, 2020
17 tasks
@ljq8896
Copy link

ljq8896 commented Oct 6, 2022

Sorry but where is the 0.01bit in the spec? Is this still Implementing? I could only see [Validator](Construct attestation
attestation.data, attestation.aggregation_bits, and attestation.signature are unchanged from Phase 0. But safety/validity in signing the message is premised upon calculation of the "custody bit" [TODO].)?

@ljq8896
Copy link

ljq8896 commented Oct 6, 2022

Sorry but where is the 0.01bit in the spec? Is this still Implementing? I could only see [Validator](Construct attestation attestation.data, attestation.aggregation_bits, and attestation.signature are unchanged from Phase 0. But safety/validity in signing the message is premised upon calculation of the "custody bit" [TODO].)?

I try to understand it. There will not be a custody bit in an attestation. Honest Validator just don't sign when it's 1 for 0.1% of the time. So if anyone find a Validator sign the bit calculated 1, the validator can be slashed.

@dankrad
Copy link
Contributor Author

dankrad commented Oct 6, 2022

Hi, this is not a place for a discussion. If you have questions, you can ask them for example on the ethresearch post: https://ethresear.ch/t/a-0-001-bit-proof-of-custody/7409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change to 2^14 epoch custody periods
3 participants