Fix ShardTransition.shard_data_roots
and add custody game block-level tests
#1937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(pending on #1928 refactoring)
Issues
shard_data_roots
How did I fix it
ShardTransition.shard_data_roots
: useget_block_data_merkle_root
helper to calculate the root.get_valid_custody_chunk_response
testing helper: acceptblock_length_or_custody_data
test_with_shard_transition_with_custody_challenge_and_response
,test_custody_key_reveal
,test_early_derived_secret_reveal
,test_custody_slashing
test cases for increasing testing coverage.run_beacon_block
: should yield thesigned_beacon_block
get_attesting_indices
cache: addrandao_mixes
to the cache keys