Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process_attestation: Validate epoch before using it #1996

Merged
merged 1 commit into from
Jul 24, 2020

Commits on Jul 24, 2020

  1. process_attestation: Validate epoch before using it

    `data.target.epoch` is used to count the active validator set.
    
    Because `get_committee_count_per_slot` is extremely inefficient the way
    the spec is written, clients cache it, or the underlying active
    validator set.
    
    Performing the checks in the given order leads to a (very unlikely)
    security issue where the a cold and above all, distant value may get
    used which may be costly - reordering the checks brings the value into a
    more reasonable range before using it.
    arnetheduck committed Jul 24, 2020
    Configuration menu
    Copy the full SHA
    6f7652d View commit details
    Browse the repository at this point in the history