Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syncnets data to Altair MetaData #2352

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Add syncnets data to Altair MetaData #2352

merged 1 commit into from
Apr 27, 2021

Conversation

ralexstokes
Copy link
Member

Fixes #2347.

@pawanjay176
Copy link
Contributor

This would also add a v2 version for GetMetaData response in rpc right?

@djrtwo
Copy link
Contributor

djrtwo commented Apr 27, 2021

This would also add a v2 version for GetMetaData response in rpc right?

Yes, I think that's the simplest way to handle the content changes on the MetaData type here.

We'd probably also want to specify that this new GetMetaData version can be enabled at anytime prior to the fork

@ralexstokes
Copy link
Member Author

Added the "get metadata v2" req/resp endpoint -- the guide already discusses upgrading to v2 ahead of the fork so it seems that has already been covered

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Altair p2p MetaData should contain syncnets field
3 participants