Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor altair cleanups #2362

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Minor altair cleanups #2362

merged 3 commits into from
Apr 28, 2021

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Apr 27, 2021

  • add altair p2p to readme
  • SyncCommitteeSigningData -> SyncAggregatorSelectionData
  • minor copy edits to altair/validator

@djrtwo djrtwo requested a review from ralexstokes April 27, 2021 21:08
hwwhww
hwwhww approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

specs/altair/validator.md Outdated Show resolved Hide resolved
specs/altair/validator.md Outdated Show resolved Hide resolved
specs/altair/validator.md Outdated Show resolved Hide resolved
@hwwhww hwwhww added general:presentation Presentation (as opposed to content) scope:networking scope:v-guide Validator guide labels Apr 28, 2021
@djrtwo @hwwhww
Apply suggestions from code review
e89fae8 
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
@djrtwo djrtwo merged commit c3dfc2e into dev Apr 28, 2021
@djrtwo djrtwo deleted the sync-cleanup branch April 28, 2021 14:42
@twoeths twoeths mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1Cpw7MiLzAsTFBiBRrMQLuUwyDRrWY7nGx 1Cpw7MiLzAsTFBiBRrMQLuUwyDRrWY7nGx 1Cpw7MiLzAsTFBiBRrMQLuUwyDRrWY7nGx approved these changes

@hwwhww hwwhww hwwhww approved these changes

@ralexstokes ralexstokes Awaiting requested review from ralexstokes

Assignees
No one assigned
Labels
general:presentation Presentation (as opposed to content) scope:networking scope:v-guide Validator guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djrtwo @hwwhww @1Cpw7MiLzAsTFBiBRrMQLuUwyDRrWY7nGx