Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify sync committee aggregates #2370

Merged
merged 3 commits into from
May 6, 2021
Merged

Simplify sync committee aggregates #2370

merged 3 commits into from
May 6, 2021

Conversation

ralexstokes
Copy link
Member

The current Altair spec provides multiple partitions of the full sync committee with the idea being that light clients could follow some subset of their choosing to enable a trade-off between security and performance.

However, to efficiently implement this feature the BeaconBlock definition in Altair needs to support a distinct (aggregate) signature for each partition stored in the BeaconState. And currently we only have one such signature.

To reconcile this discrepancy, we can either add multiple signatures to the BeaconBlock (along w/ the corresponding increase in consensus complexity) or we can omit the in-protocol aggregation. This PR presents the latter solution and I'd argue it is a better trade-off at this point in time given the relative maturity of Altair client implementations.

@hwwhww hwwhww added the Altair aka HF1 label May 4, 2021
@hwwhww hwwhww added this to the v1.1.0-alpha.4 milestone May 4, 2021
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

agreed that we could include a bit more in the docstring about usage and gotchas on the aggregate

@ralexstokes
Copy link
Member Author

@hwwhww @djrtwo added some notes about duplicate pubkeys -- light clients should start with a bitfield and just blindly unaggregate based on participation so i'm not too worried about bugs here, but more documentation never hurts

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@djrtwo djrtwo merged commit 609172d into ethereum:dev May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Altair aka HF1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants