-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify sync committee aggregates #2370
Merged
djrtwo
merged 3 commits into
ethereum:dev
from
ralexstokes:simplify-sync-committee-aggregates
May 6, 2021
Merged
Simplify sync committee aggregates #2370
djrtwo
merged 3 commits into
ethereum:dev
from
ralexstokes:simplify-sync-committee-aggregates
May 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
commented
May 1, 2021
hwwhww
reviewed
May 4, 2021
djrtwo
approved these changes
May 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
agreed that we could include a bit more in the docstring about usage and gotchas on the aggregate
hwwhww
approved these changes
May 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
djrtwo
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Altair spec provides multiple partitions of the full sync committee with the idea being that light clients could follow some subset of their choosing to enable a trade-off between security and performance.
However, to efficiently implement this feature the
BeaconBlock
definition in Altair needs to support a distinct (aggregate) signature for each partition stored in theBeaconState
. And currently we only have one such signature.To reconcile this discrepancy, we can either add multiple signatures to the
BeaconBlock
(along w/ the corresponding increase in consensus complexity) or we can omit the in-protocol aggregation. This PR presents the latter solution and I'd argue it is a better trade-off at this point in time given the relative maturity of Altair client implementations.