Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change base_fee_per_gas type to Bytes32 #2550

Merged
merged 2 commits into from
Aug 16, 2021
Merged

Change base_fee_per_gas type to Bytes32 #2550

merged 2 commits into from
Aug 16, 2021

Conversation

mkalinin
Copy link
Collaborator

A solution alternative to #2548

What's done:

  • base_fee_per_gas type changed to Bytes32
  • base_fee_per_gas validation and related computations are removed from the beacon chain

@mkalinin mkalinin mentioned this pull request Aug 13, 2021
Closed
@mkalinin
Copy link
Collaborator Author

Changed base_fee_per_gas serialization to little-endian, the corresponding constant is also updated.

protolambda
protolambda approved these changes Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little-endian is nice for uint256 SSZ compat (if we later decide to compute or use in the beacon chain), and simple enough to convert to big-endian as part of the payload-decoding on the execution-client side. LGTM

@protolambda protolambda merged commit 958ad9a into ethereum:dev Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potuz potuz potuz left review comments

@djrtwo djrtwo djrtwo approved these changes

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkalinin @djrtwo @potuz @protolambda