Withdrawals push #2836

djrtwo · 2022-02-23T22:06:56Z

BeaconState maintains a queue of withdrawal_receipts (one receipt added for each call to withdraw())
min(MAX_WITHDRAWAL_TRANSACTIONS_PER_PAYLOAD, len(withdrawal_receipts)) receipts are dequeued into ExecutionPayload at each slot
Validator updates on how to build such payloads using the ExecutionEngine interface
add a bunch of tests for process_withdrawals and process_full_withdrawals

minor Merge and forkchoice updates release

Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>

release v1.1.7

release v1.1.8

mkalinin · 2022-02-24T11:46:36Z

We may also consider a separate Withdrawal operation on EL side to avoid mixing it with application layer transactions. A list of such operations could be a replacement for a list of ommers in the block body. Processing withdrawals is going to be very simple and could be a replacement of ommers processing logic.

specs/capella/beacon-chain.md

Ensure that the SSZ object classes are ordered

specs/capella/beacon-chain.md

vshvsh · 2022-03-12T17:21:37Z

We've been working on a proposal for execution layer only push with a mechanism closer to how the deposit contract works:
generalized message bus, partial withdrawals based on it. Maybe this will be of use in the discussion.

hwwhww

Great work!

I've run --preset=mainnet with this PR successfully.

Should we finish tests/core/pyspec/eth2spec/test/capella/fork/test_capella_fork_random.py in this PR? Or leave a TODO comment here?

specs/capella/beacon-chain.md

mkalinin · 2022-03-17T12:11:09Z

specs/capella/beacon-chain.md

+```python
+def process_block(state: BeaconState, block: BeaconBlock) -> None:
+    process_block_header(state, block)
+    if is_execution_enabled(state, block.body):


I think that this check and other checks in the spec that are related to the Merge transition should be removed in a cleanup fork after the Merge. Not directly related to Cappella but worth keeping in mind.

yeah, I think so too

will address in separate PR. It needs some testing fixes -- e.g. all transition tests need to be labeled with_only_bellatrix

Should be reviewed. There is a problem between the account and management account is being reviewed

specs/capella/fork-choice.md

ralexstokes

great work! left some comments

edit: ~~i'll make a separate pass on the tests~~ left one comment on a test case, otherwise they are a great start!

specs/capella/beacon-chain.md

specs/capella/fork-choice.md

specs/capella/validator.md

tests/core/pyspec/eth2spec/test/capella/block_processing/test_process_withdrawals.py

Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>

…nto withdrawals-push

hwwhww

lgtm!

djrtwo and others added 20 commits November 23, 2021 17:11

Merge pull request #2733 from ethereum/dev

c81c27e

minor Merge and forkchoice updates release

basic capella withdrawal in place

4f24fe4

add capella to circleci build

155863d

remove capella built files

b7308e0

fix tsts

78d5583

Apply suggestions from code review

ca74094

Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>

add withdrawn_epoch to capella validators

3024dc8

add capella circleci workflow

2010994

clean up some withdrawal logic and add tests

180abb9

lint

6969c8a

fix forkchoice tests

59d4821

remove unnecessary definitions from CapellaSpecBuilder

365b1f4

Merge pull request #2771 from ethereum/dev

93c933c

release v1.1.7

Merge pull request #2778 from ethereum/dev

180855b

release v1.1.8

Resolve conflicts

171a9cc

Add capella to test coverage report target

3b474eb

Move capella fork tests to the correct folder and resolve conflicts

cbf314c

modified withdrawals for push

e80a142

Merge branch 'dev' into withdrawals-push

2026103

fix tx type

e49f73c

djrtwo changed the title ~~Withdrawals push~~ [WIP]Withdrawals push Feb 23, 2022

djrtwo changed the title ~~[WIP]Withdrawals push~~ [WIP] Withdrawals push Feb 23, 2022

Ensure that the SSZ classes are ordered

eef2dbb

ralexstokes reviewed Feb 24, 2022

View reviewed changes

specs/capella/beacon-chain.md Outdated Show resolved Hide resolved

Update specs/capella/beacon-chain.md

0b89c7f

ralexstokes reviewed Feb 24, 2022

View reviewed changes

specs/capella/beacon-chain.md Outdated Show resolved Hide resolved

djrtwo added 3 commits February 24, 2022 14:17

Merge pull request #2837 from ethereum/fix-build_spec

fb90451

Ensure that the SSZ object classes are ordered

fix lint

d513f5c

fix fully withdrawal tests

f5dab5b

ralexstokes reviewed Mar 8, 2022

View reviewed changes

specs/capella/beacon-chain.md Show resolved Hide resolved

Merge branch 'dev' into withdrawals-push

507f550

djrtwo force-pushed the withdrawals-push branch from 531fdb9 to 1ab5206 Compare March 10, 2022 18:01

minor withdrawals renamings

3dd83cf

djrtwo force-pushed the withdrawals-push branch from 1ab5206 to 3dd83cf Compare March 10, 2022 19:30

This was referenced Mar 15, 2022

[WIP] Withdrawals pull. #2759

Closed

Withdrawals tracking issue #2758

Closed

djrtwo changed the title ~~[WIP] Withdrawals push~~ Withdrawals push Mar 16, 2022

djrtwo added 2 commits March 16, 2022 12:01

add validator and fork-choice mods for withdrawals in capella

255e942

add tests for process_withdrawals

36aae1d

hwwhww reviewed Mar 17, 2022

View reviewed changes

specs/capella/beacon-chain.md Outdated Show resolved Hide resolved

specs/capella/beacon-chain.md Outdated Show resolved Hide resolved

specs/capella/beacon-chain.md Outdated Show resolved Hide resolved

mkalinin reviewed Mar 17, 2022

View reviewed changes

specs/capella/fork-choice.md Show resolved Hide resolved

ralexstokes reviewed Mar 17, 2022

View reviewed changes

tests/core/pyspec/eth2spec/test/capella/block_processing/test_process_withdrawals.py Show resolved Hide resolved

ralexstokes mentioned this pull request Mar 17, 2022

Beacon Chain Withdrawals for Shanghai ethereum/pm#495

Closed

djrtwo and others added 8 commits March 22, 2022 07:55

refine naming for withdrawals

493b169

topo sort

9a8ff4f

Apply suggestions from code review

03f9503

Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>

Merge branch 'withdrawals-push' of github.com:ethereum/eth2.0-specs i…

43ce98b

…nto withdrawals-push

Merge branch 'dev' into withdrawals-push

c10d219

build

a2db446

toc

b469593

toc

8a388f2

hwwhww approved these changes Mar 24, 2022

View reviewed changes

djrtwo merged commit 656e6ae into dev Mar 24, 2022

djrtwo deleted the withdrawals-push branch March 24, 2022 16:08

wemeetagain mentioned this pull request May 25, 2022

Ensure feature parity with consensus spec v1.2.0 ChainSafe/lodestar#4060

Closed

18 tasks

ralexstokes mentioned this pull request Jun 7, 2022

Partial withdrawals #2862

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Withdrawals push #2836

Withdrawals push #2836

djrtwo commented Feb 23, 2022 •

edited

Loading

mkalinin commented Feb 24, 2022

vshvsh commented Mar 12, 2022

hwwhww left a comment

mkalinin Mar 17, 2022

djrtwo Mar 17, 2022

amirkhan7javi Jul 2, 2023

ralexstokes left a comment •

edited

Loading

hwwhww left a comment

Withdrawals push #2836

Withdrawals push #2836

Conversation

djrtwo commented Feb 23, 2022 • edited Loading

mkalinin commented Feb 24, 2022

vshvsh commented Mar 12, 2022

hwwhww left a comment

Choose a reason for hiding this comment

mkalinin Mar 17, 2022

Choose a reason for hiding this comment

djrtwo Mar 17, 2022

Choose a reason for hiding this comment

amirkhan7javi Jul 2, 2023

Choose a reason for hiding this comment

ralexstokes left a comment • edited Loading

Choose a reason for hiding this comment

hwwhww left a comment

Choose a reason for hiding this comment

djrtwo commented Feb 23, 2022 •

edited

Loading

ralexstokes left a comment •

edited

Loading