Move is_post_xxx functions to new module
#3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the `is_post_xxx` functions to a separate module allows `genesis` to also use them (cyclic import from `context` prevented this before). This allows removing `FORKS_BEFORE_ALTAIR` and `FORKS_BEFORE_BELLATRIX` constants and adding a more general `is_post_fork` function that needs less maintenance. This then allows definition of `with_all_phases_from` to streamline the implementation of the `with_xxx_and_later` decorators.
hwwhww
approved these changes
Nov 9, 2022
| @@ -0,0 +1,33 @@ | |||
| from .constants import ( | |||
There was a problem hiding this comment.
Although we had Phase0, now I wish we could retire "phases" someday since developments are in-parallel.
What do you think about protocols.py or forks.py?
There was a problem hiding this comment.
I will go with forks.py then. It is consistent with the fork=... naming when running make citest.
I will not touch the decorators such as @with_all_phases for now, as it is out of scope of this PR.
| return b in [PHASE0, ALTAIR] | ||
| if a == PHASE0: | ||
| return b in [PHASE0] | ||
| assert False # Fork is missing |
There was a problem hiding this comment.
Suggested change
| assert False # Fork is missing | |
| raise ValueError("Wrong fork name %s" % a) |
Co-authored-by: Hsiao-Wei Wang <hsiaowei.eth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the
is_post_xxxfunctions to a separate module allowsgenesisto also use them (cyclic import fromcontextprevented this before). This allows removingFORKS_BEFORE_ALTAIRandFORKS_BEFORE_BELLATRIXconstants and adding a more generalis_post_forkfunction that needs less maintenance. This then allows definition ofwith_all_phases_fromto streamline the implementation of thewith_xxx_and_laterdecorators.