Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add historical_summaries setup to fork.md #3201

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Add historical_summaries setup to fork.md #3201

merged 1 commit into from
Jan 11, 2023

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jan 10, 2023 •
edited
Loading

Thank @g11tech for pointing it out!

Issue

#3165 added a new field to BeaconState so we should have updated eip4844/fork.md correspondingly.

How I fixed it

  • [eip4844/fork.md] Add historical_summaries=pre.historical_summaries
  • [capella/fork.md] To make it clear, add historical_summaries=List[HistoricalSummary, HISTORICAL_ROOTS_LIMIT]([]). (it's the default value though)

Note: This PR should only change EIP-4844 logic and test vectors.

@djrtwo
I can push a hotfix test vector release v1.3.0-rc.0-hotfix this week, or should we cut a v1.3.0-rc.1?

@hwwhww hwwhww added the Deneb was called: eip-4844 label Jan 10, 2023
@hwwhww hwwhww requested a review from djrtwo January 10, 2023 09:04
g11tech
g11tech approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@timbeiko timbeiko mentioned this pull request Jan 10, 2023
Closed
@tersec tersec mentioned this pull request Jan 11, 2023
Merged
djrtwo
djrtwo approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@djrtwo djrtwo merged commit 71d66af into dev Jan 11, 2023
@djrtwo djrtwo deleted the fix-fork-historical-summaries branch January 11, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

@g11tech g11tech g11tech approved these changes

Assignees
No one assigned
Labels
Deneb was called: eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hwwhww @djrtwo @g11tech