Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated eip4844 references to deneb #3215

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Updated eip4844 references to deneb #3215

merged 3 commits into from
Feb 9, 2023

Conversation

rolfyone
Copy link
Contributor

Fixes #3207

djrtwo
djrtwo reviewed Jan 19, 2023
View reviewed changes
Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! we'll also need to move all the files to specs/deneb

also, looks like there are a number of unnecessary merge commits. can you rebase this on current dev?

@rolfyone
Copy link
Contributor Author

Sounds fair - will give it a go!

@rolfyone
Copy link
Contributor Author

I made a big mess of rebasing this, will reach out to someone next week and try to clean it up

djrtwo
djrtwo reviewed Jan 23, 2023
View reviewed changes
tests/core/pyspec/eth2spec/test/helpers/constants.py
@@ -14,25 +14,25 @@
SHARDING = SpecForkName('sharding')
CUSTODY_GAME = SpecForkName('custody_game')
DAS = SpecForkName('das')
EIP4844 = SpecForkName('eip4844')
DENEB = SpecForkName('deneb')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is line that is giving us problems in the CI. Seems like a caching problem because this is correct

cc: @hwwhww

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

summon @parithosh (not in a hurry!)

@hwwhww hwwhww added the Deneb was called: eip-4844 label Jan 26, 2023
@g11tech g11tech mentioned this pull request Jan 30, 2023
Merged
@rolfyone rolfyone marked this pull request as ready for review February 2, 2023 06:35
@rolfyone
Copy link
Contributor Author

rolfyone commented Feb 5, 2023

I'm not sure how to progress this one...

hwwhww
hwwhww reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfyone great work!

We can ignore the GitHub Actions errors for now. CircleCI still covers all tests.

The logic looks fine, but there are still some EIP-4844 keywords in this branch.

The moment we merge this PR will make the other ~10 open EIP-4844 PRs need to be rebased/fixed conflicts 😅 But still it's better to do it sooner than later.

README.md Outdated Show resolved Hide resolved
@zilm13 zilm13 mentioned this pull request Feb 7, 2023
Merged
2 tasks
@mehdi-aouadi mehdi-aouadi mentioned this pull request Feb 7, 2023
Closed
@hwwhww hwwhww mentioned this pull request Feb 9, 2023
Closed
hwwhww
hwwhww approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rolfyone!!!

@hwwhww hwwhww merged commit ffacbb4 into ethereum:dev Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo left review comments

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
Deneb was called: eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename EIP-4844 specs to Deneb 🦢
4 participants
@rolfyone @djrtwo @hwwhww @Mexeey