Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Makefile: only list the spec names once #3276

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Feb 28, 2023

Issue

Every time I added a new spec, I forget to add it to the linter and test coverage scope.

How did I fix it

Add a list ALL_EXECUTABLE_SPECS = phase0 altair bellatrix capella deneb. So we only have to update this variable for future specs.

Note: we still have to manually update MARKDOWN_FILES content because the paths differ.

Copy link
Contributor

@djrtwo djrtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

can we not do the specs by wild-carding the sub-dir even for specs without it?

@hwwhww
Copy link
Contributor Author

hwwhww commented Feb 28, 2023

I just found that MARKDOWN_FILES is only for check_toc and all the files under specs are ToC-checked. So we can wild-card all files under specs now.

@hwwhww hwwhww merged commit 1d65db0 into dev Feb 28, 2023
@hwwhww hwwhww deleted the makefile-for-loop branch February 28, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants