Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP6914 - Reuse indexes with full sweep #3307
EIP6914 - Reuse indexes with full sweep #3307
Changes from 2 commits
f9b359b
ee3e1ac
c1273bb
314b040
f696b30
3d9c87b
25ea243
622c9b9
accf99f
498fbd0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting to define
add_validator_to_registry
(there could be a better name) and doing the following refactor:Phase0
Replace the two lines with a call to this method
Altair
Modify
add_validator_to_registry
to be aligned with Altair updates. Which also makes Altair spec leaner as a side effect (no need to redefine entireapply_deposit
, justadd_validator_to_registry
).Reuse indexes
Modify
add_validator_to_registry
respectively, and encapsulateget_index_for_new_validator
and update or append logic in this feature only.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent of
update_or_append_to_list
was to prevent having to duplicate initialization statements, which will keep growing with every fork. And to keep this doc agnostic of altair initialization itself. No strong opinion on either way. I'll PR theadd_validator_to_registry
separately since it's mostly orthogonal to the change