Code

Confirmation Rule#3339

Code

Open

saltiniroberto wants to merge 171 commits intoethereum:devethereum/consensus-specs:devfrom saltiniroberto:confirmation_rulesaltiniroberto/eth2.0-specs:confirmation_ruleCopy head branch name to clipboard

+1,277-10

Commits

Commits on Apr 12, 2023

• Change to filter_block_tree required for the confirmation rule

  saltiniroberto

  committed
  d137dbe

Commits on Apr 13, 2023

• First draft implementation of the confirmation rule

  saltiniroberto

  committed
  e04c678

• Rename safe-head.md

  saltiniroberto

  committed
  0a2e654

• Require to run isConfirmed only on blocks from the current epoch

  saltiniroberto

  committed
  d51ae0c

• Move get_leaf_block_roots to unused function section

  saltiniroberto

  committed
  3c145ec

Commits on Apr 15, 2023

• Compute remaining voting weight starting from current_slot + 1 rather than block.slot + 1

  saltiniroberto

  committed
  124eaba

Commits on Apr 16, 2023

• Fix typo

  saltiniroberto

  committed
  1b3eb7c

Commits on Apr 18, 2023

• Make mypy happy

  saltiniroberto

  committed
  da75a4e

• Fix formula in isOneConfirmed

  saltiniroberto

  committed
  e622582

• Change ffg weight calculation and fix error in other fomula

  saltiniroberto

  committed
  7cd6f41

• Account for proposer boost

  saltiniroberto

  committed
  4be510e

• Fix minor issue

  saltiniroberto

  committed
  be8bfce

Commits on Apr 19, 2023

• Fix will_block_checkpoint_be_justified_by_end_of_the_current_epoch + use conversion to int to avoid overflows

  saltiniroberto

  committed
  e4ad646

• Merge branch 'ethereum:dev' into confirmation_rule

  saltiniroberto

  authored
  9bd335c

• minor updates

  saltiniroberto

  committed
  f454b99

• Increase style check line length for ease of development

  saltiniroberto

  committed
  6f56d90

Commits on Apr 20, 2023

• Use latest_message for computing get_ffg_weight_supporting_checkpoint_for_block

  saltiniroberto

  committed
  dc95b43

• Add helper function for calculating score

  saltiniroberto

  committed
  89a2818

Commits on Apr 21, 2023

• Add functions to calculate score

  saltiniroberto

  committed
  a68c853

• Use underscore for all function names

  saltiniroberto

  committed
  c29053b

Commits on Apr 26, 2023

• Removed files committed by mistake

  saltiniroberto

  committed
  a6c91b4

• Remove other files committed by mistake

  saltiniroberto

  committed
  a69530d

• Moved functions for calculating the confirmation score to a separate

  Show description for 5f8e88e
  saltiniroberto

  committed
  5f8e88e

• Added very brief explainer

  saltiniroberto

  committed
  3b6afe5

• Add back get_safe_execution_payload_hash

  saltiniroberto

  committed
  ad97ef9

• Revert ffg support commputation to use attestations in leaf blocks

  saltiniroberto

  committed
  bcc1c3f

Commits on Apr 27, 2023

• Doc

  saltiniroberto

  committed
  4d7b715

• Make mypy happy

  saltiniroberto

  committed
  c67cf35

• doctoc

  saltiniroberto

  committed
  c3a0f7f

• doc

  saltiniroberto

  committed
  2493cb3

• Add doc and fix bug in get_max_adversary_percentage_to_ensure_block_checkpoint_is_justified_by_the_end_of_the_current_epoch

  saltiniroberto

  committed
  d338119

• Merge remote-tracking branch 'upstream/dev' into confirmation_rule

  saltiniroberto

  committed
  55bdbe0

• Removed unused files

  saltiniroberto

  committed
  08e3abd

• Remove unrequired files

  saltiniroberto

  committed
  3e29857

• first pass for review

  adiasg

  committed
  3066ad4

Commits on Apr 28, 2023

• Merge pull request #2 from saltiniroberto/confirmation_rule_adiasg

  Show description for d53a44a
  saltiniroberto

  authored
  d53a44a

• Small fix to the doc

  saltiniroberto

  committed
  9354dc7

• Calculate vote_weight_till_now as diff between total and future

  saltiniroberto

  committed
  1dff966

• Fix link in bellatrix fork choice

  saltiniroberto

  committed
  bd85b41

Commits on May 4, 2023

• review pass 2

  adiasg

  committed
  16b26c1

• Merge pull request #3 from saltiniroberto/confirmation_rule_adiasg

  Show description for 9ccf48b
  saltiniroberto

  authored
  9ccf48b

• Merge remote-tracking branch 'upstream/dev' into confirmation_rule

  saltiniroberto

  committed
  b8ac374

Commits on May 15, 2023

• update confirmation score calc

  adiasg

  committed
  b99e31f

• remove current_slot parameter

  adiasg

  committed
  0117eed

• use simplified comm weight calc for safe block

  adiasg

  committed
  446baeb

• add function for computing proposer score

  adiasg

  committed
  673b4f4

• remove old code

  adiasg

  committed
  38ace65

• use get_checkpoint_block

  adiasg

  committed
  ca5006d

Commits on May 16, 2023

• readability refactor

  adiasg

  committed
  9475b62

• use float calculations

  adiasg

  committed
  668c97d

• Fix get_proposer_score

  saltiniroberto

  committed
  6ccc528

• Fix lint error

  saltiniroberto

  committed
  97dc8be

• Merge pull request #5 from saltiniroberto/confirmation_rule_adiasg_roberto

  Show description for 0b2751d
  adiasg

  authored
  0b2751d

• fix lint errors

  adiasg

  committed
  49a1365

• update toc

  adiasg

  committed
  6a75d4e

• function renaming

  adiasg

  committed
  03b194e

Commits on May 17, 2023

• wip - update conf score comments

  adiasg

  committed
  b843dad

• fix multiplier

  adiasg

  committed
  185338c

• remove comments

  adiasg

  committed
  5c38f67

• simplify confirmation score functions

  adiasg

  committed
  ba7cb1f

• attach paper

  adiasg

  committed
  c0efc70

• Fix calculation bug in remaining_slots_in_current_epoch

  saltiniroberto

  committed
  0041a00

• Merge pull request #6 from saltiniroberto/confirmation_rule_adiasg_roberto

  Show description for d8cbfbc
  adiasg

  authored
  d8cbfbc

• minor update

  adiasg

  committed
  569366b

• Merge pull request #4 from saltiniroberto/confirmation_rule_adiasg

  Show description for dca4c34
  adiasg

  authored
  dca4c34

• change typing

  adiasg

  committed
  d792899

• Update introductory notes

  adiasg

  committed
  0d9e1a1

• rename conflicting function

  adiasg

  committed
  ee3991f

Commits on May 18, 2023

• typo correction

  adiasg

  committed
  8b3ab9c

Commits on Jun 5, 2023

• apply review from @hwwhww and @mkalinin

  adiasg

  committed
  79ffac1

• function name case suggestion by @mkalinin

  adiasg

  committed
  448ffac

• some more suggestions from @mkalinin

  adiasg

  committed
  c79df70

Commits on Jun 7, 2023

• Apply suggestions from code review

  Show description for 91643d9
  

  adiasg

  and

  saltiniroberto

  authored
  91643d9

• commit change

  saltiniroberto

  authored
  17d528a

Commits on Jun 15, 2023

• Fix small bug

  saltiniroberto

  committed
  50e94fa

• Port FFG support calculation to Altair logic

  saltiniroberto

  committed
  988b875

• Limit confirmation score negative values to -1

  saltiniroberto

  committed
  b8c2ba6

• Fix ethereum#3339 (comment)

  saltiniroberto

  committed
  bb4a6aa

• Fix doc

  Show description for 783762a
  

  saltiniroberto

  and

  etan-status

  authored
  783762a

• Fix doc

  saltiniroberto

  committed
  956a0b7

• Fix blank lines

  saltiniroberto

  committed
  28e3f64

• Fix types in get_committee_weight_between_slots

  saltiniroberto

  committed
  bfe43ce

• Move from floats to ints

  saltiniroberto

  committed
  ddf8772

• Update doc to reflect usage of unbound int rather than floats

  saltiniroberto

  committed
  ce5670a

• Moved missed float computations to int and fixed linting

  saltiniroberto

  committed
  dd22c68

• Replace float with integer arithmetic for calculations in get_committee_weight_between_slots

  saltiniroberto

  committed
  9933161

Commits on Jun 16, 2023

• Fix https://github.com/ethereum/consensus-specs/pull/3339/files#r1230361554

  saltiniroberto

  committed
  1269ea5

• Fix bug in fetching checkpoint state in get_ffg_confirmation_score and is_ffg_confirmed

  saltiniroberto

  committed
  b9919b6

Commits on Jun 17, 2023

• Make flake8 happy

  saltiniroberto

  committed
  0530af7

• Use pulled up checkpoint state in get_ffg_support

  saltiniroberto

  committed
  24b66c8

• Fix bug in get_committee_weight_between_slots

  saltiniroberto

  committed
  616ae4c

• Revert "Fix bug in get_committee_weight_between_slots"

  Show description for ae0bf67
  saltiniroberto

  committed
  ae0bf67

• Fix bug in get_committee_weight_between_slots

  saltiniroberto

  committed
  9bcefc1

• Fix bug in get_ffg_support

  saltiniroberto

  committed
  444a7e6

• Fix bug in get_confirmation_score

  saltiniroberto

  committed
  b0b93f8

• Fix div by 0 in get_ffg_confirmation_score

  saltiniroberto

  committed
  a3c463f

• Add slashing_th par to get_confirmation_score and improve pre div-by-0 fix

  saltiniroberto

  committed
  d80b701

Commits on Jun 21, 2023

• Allow is_confirmed for blocks from the previous epoch

  saltiniroberto

  committed
  3ea5598

• Extend handling of previous epoch to get_score

  saltiniroberto

  committed
  3ce6a0e

• Use block state for balances and refactor get_remaining_weight

  saltiniroberto

  committed
  8737f14

• Fix return type issue in get_committee_weight_between_slots

  saltiniroberto

  committed
  72fb786

• Refactor get_ffg_confirmation_score to reduce code repetition

  saltiniroberto

  committed
  0e2e77a

• Refactor is_ffg_confirmed to reduce code duplication

  saltiniroberto

  committed
  1fb41c4

• doctoc

  saltiniroberto

  committed
  9a45487

• Add tests

  saltiniroberto

  committed
  0d93f11

• Refactor tests

  saltiniroberto

  committed
  3e4837a

• Add get_confirmation_score checks in tests

  saltiniroberto

  committed
  2aba14f

• Make linter happy

  saltiniroberto

  committed
  a77a8b0

Commits on Jul 10, 2023

• Apply some of djrtwo’s review suggestions

  Show description for 12de731
  

  saltiniroberto

  and

  djrtwo

  authored
  12de731

• Improve calculation for edge case in get_committee_weight_between_slots

  saltiniroberto

  committed
  2760c72

• Improve get_committee_weight_between_slots (more precise calculations and readability)

  saltiniroberto

  committed
  4433813

Commits on Jul 11, 2023

• Remove leftovers from previous code refactoring

  saltiniroberto

  committed
  78bcb38

• Aligned long function defs to the convention used in the rest of the specs

  saltiniroberto

  committed
  c32b9ef

• Simplify check on block epoch

  saltiniroberto

  committed
  7333dde

• Remove duplicate line.

  saltiniroberto

  committed
  bb7fe9a

• Fix doc for is_ffg_confirmed & helpers

  saltiniroberto

  committed
  b69dfb6

• Rename vars in is_confirmed

  saltiniroberto

  committed
  20c101f

Commits on Jul 18, 2023

• Combine code for previous and current epoch in is_ffg_confirmed and get_ffg_confirmation_score + improve doc for get_ffg_confirmation_score

  saltiniroberto

  committed
  b1d631a

• Use inline comments style rather than docstrings for comments related to specific parts of a method

  saltiniroberto

  committed
  ad268ec

Commits on Jul 19, 2023

• Fix bug in get_committee_weight_between_slots

  Show description for e29d0ac
  

  saltiniroberto

  and

  fradamt

  authored
  e29d0ac

Commits on Jul 21, 2023

• Move config par to Configuration, add constant definition and improve description in config table

  saltiniroberto

  committed
  e955658

Commits on Jul 22, 2023

• Implement early exit criteria for is_lmd_confirmed

  saltiniroberto

  committed
  913260b

Commits on Jul 23, 2023

• Add link to committee weight estimation, introduce adjustment factor and fix possible rounding issue

  saltiniroberto

  committed
  5e05100

• Use compute_slots_since_epoch_start in get_committee_weight_between_slots

  saltiniroberto

  committed
  ae1ef29

• Fix variable names in get_committee_weight_between_slots

  saltiniroberto

  committed
  24b6db2

• Use ceiling division everywhere in get_committee_weight_between_slots

  saltiniroberto

  committed
  1340706

• Replace pythonic starred expression in get_leaf_block_roots with for loop

  saltiniroberto

  committed
  49a2a30

• Rename var in get_ffg_support

  saltiniroberto

  committed
  c41b95d

• Allow for blocks from the previous epoch in find_confirmed_block, re-add get_safe_beacon_block_root and restore get_safe_execution_payload_hash to use get_safe_beacon_block_root

  saltiniroberto

  committed
  6961150

• Fix the level of indentation of some of the headings

  saltiniroberto

  committed
  f29df8b

• Add test for get_safe_beacon_block_root

  saltiniroberto

  committed
  d243ce8

• Temporary fork choice spec test change

  saltiniroberto

  committed
  c59f1fe

• Fix typo

  saltiniroberto

  committed
  f4a7a4f

• Add new line to make the linter happy

  saltiniroberto

  committed
  39d8b4f

• Add new line to make linter happy

  saltiniroberto

  committed
  33b555d

• Run confirmation rule tests only from bellatrix onwards

  saltiniroberto

  committed
  cfa521d

• Merge branch 'upstream/dev' into confirmation_rule

  saltiniroberto

  committed
  7dfdcd7

Commits on Jul 25, 2023

• Fix possible rounding issue in get_committee_weight_between_slots

  saltiniroberto

  committed
  0b8eb0b

• Improve doc on using unbounded integers

  Show description for 499e4f6
  

  saltiniroberto

  and

  adiasg

  authored
  499e4f6

• Restore safe-block.md for now

  saltiniroberto

  committed
  a9597c4

• Fix mistake when restoring safe-block.md in previous commit

  saltiniroberto

  committed
  528bbdc

Commits on Jul 27, 2023

• Merge commit fork-choice-changes-for-confirmaton-rule into confirmation_rule

  saltiniroberto

  committed
  4926681

• Fix error from previous merge

  saltiniroberto

  committed
  e735a58

Commits on Jul 30, 2023

• Fix comments

  Show description for 8c23187
  

  saltiniroberto

  and

  mkalinin

  authored
  8c23187

• Fix var name in get_committee_weight_between_slots

  saltiniroberto

  committed
  6692612

• Rename low lever get_confirmation* functions to compute_confirmation*

  saltiniroberto

  committed
  cd0ad10

• Use cell_div rather than the explicit formula

  Show description for e365bc4
  

  saltiniroberto

  and

  mkalinin

  authored
  e365bc4

• Rename committee_spans_full_epoch and committee_for_block_spans_full_epoch

  saltiniroberto

  committed
  d25b7ef

• Change implementation of ceil_div

  saltiniroberto

  committed
  9fa4fca

Commits on Aug 1, 2023

• Apply suggestions from @mkalinin's review

  Show description for 992dea0
  

  saltiniroberto

  and

  mkalinin

  authored
  992dea0

Commits on Aug 2, 2023

• Add handling of block from epoch prior to previous in is_confirmed

  saltiniroberto

  committed
  508327e

Commits on Aug 3, 2023

• Calculate confirmation score for blocks prior to previous epoch as well

  saltiniroberto

  committed
  d6c25e1

• Make the linter happy

  saltiniroberto

  committed
  e927509

Commits on Aug 4, 2023

• Remove get_safe_beacon_block_root and get_safe_execution_payload_hash from new confirmation rule

  saltiniroberto

  committed
  32232f6

• Apply suggestions from code review

  Show description for 3787e96
  

  saltiniroberto

  and

  hwwhww

  authored
  3787e96

Commits on Aug 7, 2023

• Stop recursion earlier in compute_lmd_confirmation_score

  saltiniroberto

  committed
  8ff01f5

Commits on Aug 8, 2023

• Refactor test to improve code reuse

  saltiniroberto

  committed
  cacdc04

• Merge commit dev branch into confirmation_rule

  saltiniroberto

  committed
  eebbe94

• Fix issue in previous merge

  saltiniroberto

  committed
  21b9d2e

Commits on May 2, 2024

• Merge 'dev' into confirmation_rule

  saltiniroberto

  committed
  dff96e3

• Update to match latest paper

  saltiniroberto

  committed
  c9caf62

• Fix lint issues

  saltiniroberto

  committed
  740be9a

Commits on May 3, 2024

• Improve doc

  saltiniroberto

  committed
  688aa19

• Fix typo

  saltiniroberto

  committed
  4ad1cc2

• Renaming

  saltiniroberto

  committed
  be3648d

• Fix lint issues

  saltiniroberto

  committed
  b89e93b

Commits on Sep 3, 2024

• Merge branch 'dev' into pr3339

  hwwhww

  committed
  696e22d

• resolve conflict

  hwwhww

  committed
  ff3daaa

• Fix argument sequence error

  hwwhww

  committed
  e0dc09b

• Move confirmation rule specs to Bellatrix

  hwwhww

  committed
  e6d9150

• Clean up phase0

  hwwhww

  committed
  687fd5c