Gossip additional LightClientFinalityUpdate on new supermajority
#3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When new finality is reached without supermajority sync committee support, trigger another event push on beacon-API and libp2p once the new finality gains supermajority support. Without this, if the first `LightClientFinalityUpdate` that advances finality has low participation, light clients monitoring gossip would likely get stuck until the next time when finality advances (1 epoch). Thanks to @DragonDev1906 for reporting this issue to Nimbus: - status-im/nimbus-eth2#5491
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Nov 15, 2023
When new finality is reached without supermajority sync committee support, trigger another event push on beacon-API and libp2p once the finality gains supermajority support. - ethereum/consensus-specs#3549
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Nov 17, 2023
When new finality is reached without supermajority sync committee support, trigger another event push on beacon-API and libp2p once the finality gains supermajority support. - ethereum/consensus-specs#3549
dapplion
reviewed
Nov 17, 2023
dapplion
approved these changes
Nov 20, 2023
hwwhww
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new finality is reached without supermajority sync committee support, trigger another event push on beacon-API and libp2p once the new finality gains supermajority support.
Without this, if the first
LightClientFinalityUpdatethat advances finality has low participation, light clients monitoring gossip would likely get stuck until the next time when finality advances (1 epoch).Thanks to @DragonDev1906 for reporting this issue to Nimbus: