-
Notifications
You must be signed in to change notification settings - Fork 973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] EIP-7594: PeerDAS protocol #3574
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
d6a37ec
Copied from Danny's ethresearch post
hwwhww 93dddd1
wip
hwwhww 504b4f9
Migrating to latest crypto APIs
hwwhww 696d443
Merge branch 'dev' into peer-das
hwwhww 2cc7c87
Fix conflict
hwwhww 665e6fa
Add `RowIndex`, `ColumnIndex` custom types in crypto doc
hwwhww 9553d54
fix typo
hwwhww a72ece8
Apply suggestions from code review
hwwhww 65be5b0
Make `CUSTODY_REQUIREMENT` unit be subnets; move some depended helper…
hwwhww 55db861
Apply suggestions from code review
hwwhww 4477cc6
Fix column computation
hwwhww 56e6a98
`verify_data_column_sidecar_kzg_proof` -> `verify_data_column_sidecar…
hwwhww edeef07
toc
hwwhww b2a4657
Merge branch 'peer-das-req-subnet-count' into peer-das
hwwhww 7aab577
Merge branch 'dev' into peer-das
hwwhww 170dae5
Apply suggestions from code review
hwwhww 547460c
Apply PR feedback
hwwhww d23452d
Deprecate `blob_sidecar_{subnet_id}`
hwwhww 87e9702
Fix `DataColumnSidecarsByRoot`
hwwhww 428c166
Apply suggestions from code review
hwwhww c47d5f3
Add `recover_matrix` and remove unused `FlatExtendedMatrix` type
hwwhww 91dbbb3
Implement `compute_extended_matrix`
hwwhww e7c0d5f
Update specs/_features/eip7594/das-core.md
hwwhww 8150f76
Apply @cskiraly's suggestion
hwwhww bb33f90
Change List length of `DataColumn` from `MAX_BLOBS_PER_BLOCK` to `MAX…
hwwhww 1acb1ff
minor arrange
hwwhww cebf78a
Apply PR feedback
hwwhww 8728561
Merge branch 'dev' into peer-das
hwwhww 5535e6a
fix conflict
hwwhww File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,6 +68,9 @@ EIP7549_FORK_EPOCH: 18446744073709551615 | |
# WHISK | ||
WHISK_FORK_VERSION: 0x08000000 # temporary stub | ||
WHISK_FORK_EPOCH: 18446744073709551615 | ||
# EIP7594 | ||
EIP7594_FORK_VERSION: 0x06000001 | ||
EIP7594_FORK_EPOCH: 18446744073709551615 | ||
|
||
|
||
# Time parameters | ||
|
@@ -165,10 +168,10 @@ WHISK_EPOCHS_PER_SHUFFLING_PHASE: 256 | |
WHISK_PROPOSER_SELECTION_GAP: 2 | ||
|
||
# EIP7594 | ||
EIP7594_FORK_VERSION: 0x06000001 | ||
EIP7594_FORK_EPOCH: 18446744073709551615 | ||
NUMBER_OF_COLUMNS: 128 | ||
DATA_COLUMN_SIDECAR_SUBNET_COUNT: 32 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For initial parametrization, I'd default to these values being equal. I'd only deviate from that |
||
MAX_REQUEST_DATA_COLUMN_SIDECARS: 16384 | ||
|
||
# [New in EIP7251] | ||
MIN_PER_EPOCH_CHURN_LIMIT_EIP7251: 128000000000 # 2**7 * 10**9 (= 128,000,000,000) | ||
MAX_PER_EPOCH_ACTIVATION_EXIT_CHURN_LIMIT: 256000000000 # 2**8 * 10**9 (= 256,000,000,000) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is derived from other preset values, would it make more sense to keep it in the preset? (i.e. modifying this
NUMBER_OF_COLUMNS
in config would require a corresponding change on theFIELD_ELEMENTS_PER_BLOB
/FIELD_ELEMENTS_PER_CELL
values?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it should be a config value, but I think it can be. I think it's okay for the config values to be derived from the preset values, but not the other way around. Preset values shouldn't be derived from config values.