Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce UINT64_MAX_SQRT #3608

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Introduce UINT64_MAX_SQRT #3608

merged 1 commit into from
Feb 19, 2024

Conversation

mkalinin
Copy link
Collaborator

Replaces the magic number introduced in #3600 with the corresponding constant

hwwhww
hwwhww approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you @mkalinin!

@hwwhww hwwhww added the general:presentation Presentation (as opposed to content) label Feb 19, 2024
@hwwhww hwwhww merged commit 1a33bf8 into dev Feb 19, 2024
30 checks passed
@hwwhww hwwhww deleted the mkalinin-patch-6 branch February 19, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
general:presentation Presentation (as opposed to content)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkalinin @djrtwo @hwwhww