Fix electra tests and enable testgen #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpected value for post-electra
hwwhww
commented
Apr 17, 2024
Comment on lines
+365
to
+372
| if is_post_electra(spec): | ||
| assert state.pending_balance_deposits[0].amount == amount | ||
| assert state.pending_balance_deposits[0].index == validator_index | ||
| else: | ||
| # Since withdrawals happen before deposits, it becomes partially withdrawable after state transition. | ||
| validator = state.validators[validator_index] | ||
| balance = state.balances[validator_index] | ||
| assert spec.is_partially_withdrawable_validator(validator, balance) |
There was a problem hiding this comment.
with the mainnet preset, it had an error because the top-up got withdrawn during the block processing. I reverted the previous fix and added different expected results; it just checks if the top-up has been appended into pending_balance_deposits.
There was a problem hiding this comment.
ah, sorry about that! this looks good for now, ill make a note to revisit if there is a better way to make this test forward-compatible
ralexstokes
approved these changes
Apr 17, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.