Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kzg_7594 test formats #3718

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add kzg_7594 test formats #3718

merged 1 commit into from
Apr 23, 2024

Conversation

jtraglia
Copy link
Member

This PR adds test formats for EIP-7594 test vectors. See:

Inspired by the KZG-4844 test formats.

@jtraglia jtraglia added the EIP-7594 PeerDAS label Apr 23, 2024
hwwhww
hwwhww approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks flawless from my bare eyes check

ralexstokes
ralexstokes approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just noting we could consider writing the big hex strings as ssz_snappy data or something in the future, if size of the test corpus becomes a concern

@ralexstokes ralexstokes merged commit 830b255 into ethereum:dev Apr 23, 2024
28 checks passed
@jtraglia jtraglia deleted the kzg-7594-formats branch April 23, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwwhww hwwhww hwwhww approved these changes

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
EIP-7594 PeerDAS scope:CI/tests/pyspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtraglia @ralexstokes @hwwhww