Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_custody_columns: Move node_id test against UINT256_MAX out of the while loop. #3742

Closed
wants to merge 2 commits into from
Closed

get_custody_columns: Move node_id test against UINT256_MAX out of the while loop. #3742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e0f2b5
`get_custody_columns`: Move `node_id` test against `UINT256_MAX` out …
nalepae May 2, 2024
eb7e592
add comment
hwwhww May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions specs/_features/eip7594/das-core.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,14 @@ class DataColumnSidecar(Container):
def get_custody_columns(node_id: NodeID, custody_subnet_count: uint64) -> Sequence[ColumnIndex]:
assert custody_subnet_count <= DATA_COLUMN_SIDECAR_SUBNET_COUNT

# Overflow prevention
if node_id == UINT256_MAX:
hwwhww marked this conversation as resolved.
Show resolved Hide resolved
node_id = NodeID(0)

subnet_ids: List[uint64] = []
i = 0
while len(subnet_ids) < custody_subnet_count:
if node_id == UINT256_MAX:
node_id = NodeID(0)

while len(subnet_ids) < custody_subnet_count:
subnet_id = (
bytes_to_uint64(hash(uint_to_bytes(uint256(node_id + i)))[0:8])
% DATA_COLUMN_SIDECAR_SUBNET_COUNT
Expand Down
Loading