Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Max Size For Columns By Range Request #3760

Merged
merged 2 commits into from
May 12, 2024
Merged

Provide Max Size For Columns By Range Request #3760

merged 2 commits into from
May 12, 2024

Conversation

nisdas
Copy link
Contributor

@nisdas nisdas commented May 9, 2024

Inline with our other P2P request types, we provide a maximum size for the list of column indexes so that they can be serialized accurately.

nisdas
nisdas commented May 9, 2024
View reviewed changes
Copy link
Contributor Author

@nisdas nisdas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that setting the max size to MAX_REQUEST_DATA_COLUMN_SIDECARS , might be too large for a by range request, however in order to serialize these lists correctly we require a fixed constant. Changed it to NUMBER_OF_COLUMNS for now

@hwwhww hwwhww merged commit 5f48840 into ethereum:dev May 12, 2024
26 checks passed
@hwwhww hwwhww added the EIP-7594 PeerDAS label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

@hwwhww hwwhww hwwhww approved these changes

Assignees
No one assigned
Labels
EIP-7594 PeerDAS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nisdas @hwwhww @dapplion