New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove `assert len(missing_cell_indices) != 0` check #3806

Merged

hwwhww merged 1 commit into dev from construct_vanishing_polynomial-hotfix

Jun 14, 2024

Contributor

hwwhww commented Jun 14, 2024

Hotfix for the v1.5.0-alpha.3 release
Revert this line from #3781

Note from @kevaundray

That was a defensive assert so it should, it’s meant to be testing that we don’t have any cells missing, but in that function the parameter is the number of missing cells (inverted), so I think it needs to be != CELLS_PER_EXT_BLOB ie not all of the missing cell ids are present


          Remove assert len(missing_cell_indices) != 0 check

483a286

hwwhww added the EIP-7594 label

kevaundray approved these changes

View reviewed changes

hwwhww merged commit 00b7468 into dev

26 checks passed

hwwhww deleted the construct_vanishing_polynomial-hotfix branch

June 14, 2024 16:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels