Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fulu configs to include MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS #4095

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jimmygchen
Copy link
Contributor

Update the following in configs:

  • Add MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS, which is referenced in fulu p2p-interface.md:
    | `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS` | `2**12` (= 4096 epochs, ~18 days) | The minimum epoch range over which a node must serve data column sidecars |
  • Remove MAX_REQUEST_BLOB_SIDECARS_FULU, as the blob sidecars p2p interface will be deprecated from Fulu, and superceded by data column RPC methods, which uses MAX_REQUEST_DATA_COLUMN_SIDECARS.

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jtraglia jtraglia merged commit b73f3bd into ethereum:dev Jan 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants