Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve test coverage for get_committee_assignment #4122

Merged

Conversation

bshastry
Copy link
Contributor

@bshastry bshastry commented Feb 6, 2025

Add assertion to test_add_to_activation_queue to verify that get_committee_assignment returns None for validators in the activation queue (inactive validators). This improves test coverage by explicitly checking the behavior of get_committee_assignment for inactive validators.

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@jtraglia jtraglia merged commit 4679aad into ethereum:dev Feb 6, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants