Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compute_commitment #617

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Fix compute_commitment #617

merged 1 commit into from
Feb 13, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Feb 13, 2019 •
edited
Loading

  1. Use + to concatenate the Merkle roots in hash function argument.
  2. Fix pad_to_power_of_2: padding with [b'\x00' * SHARD_BLOCK_SIZE],
    not [SHARD_BLOCK_SIZE].
  3. Nitpick formatting.

@hwwhww
Fix compute_commitment
f7320ec 
1. Use `+` to concatenate the merkle roots in `hash` function.
2. Fix `pad_to_power_of_2`: padding with `[b'\x00' * SHARD_BLOCK_SIZE]`,
not `[SHARD_BLOCK_SIZE]`.
@hwwhww hwwhww added the phase1 label Feb 13, 2019
@djrtwo djrtwo merged commit 83b67b6 into dev Feb 13, 2019
@djrtwo djrtwo deleted the hwwhww/fix_compute_commitment branch February 13, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
phase1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwwhww @djrtwo