Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slashed bool more Pythonicly #688

Merged
merged 3 commits into from
Feb 27, 2019
Merged

Use slashed bool more Pythonicly #688

merged 3 commits into from
Feb 27, 2019

Conversation

decanus
Copy link
Contributor

@decanus decanus commented Feb 25, 2019

No description provided.

@hwwhww hwwhww changed the title Update 0_beacon-chain.md Use slashed bool more Pythonic Feb 26, 2019
@hwwhww hwwhww changed the title Use slashed bool more Pythonic Use slashed bool more Pythonicly Feb 26, 2019
@vbuterin
Copy link
Contributor

Not sure I like this. "Verify that not proposer.slashed" doesn't sound right to anyone who's not an expert pythonista, and the spec's primary goal is being human-readable, not being pythonista-readable. Maybe one more moderate pythonization would be is False instead of == False?

@decanus
Copy link
Contributor Author

decanus commented Feb 26, 2019

@vbuterin updated

@djrtwo djrtwo merged commit bb44d25 into ethereum:dev Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinDrake JustinDrake JustinDrake approved these changes

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@decanus @vbuterin @JustinDrake @djrtwo