v5.1 Specification Update #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This partially gets the v5.1 implementation up-to-date with the spec. There is still at least one more update that needs to happen with the |
pipermerriam
force-pushed
the
piper/v51-spec-update
branch
6 times, most recently
from
94a8016
to
4026eab
Compare
pipermerriam
force-pushed
the
piper/v51-spec-update
branch
from
4026eab
to
093d6ec
Compare
pipermerriam
force-pushed
the
piper/v51-spec-update
branch
2 times, most recently
from
a912ac3
to
2ff2fc9
Compare
pipermerriam
force-pushed
the
piper/v51-spec-update
branch
2 times, most recently
from
d849863
to
fe71b79
Compare
pipermerriam
force-pushed
the
piper/v51-spec-update
branch
from
fe71b79
to
2f14a92
Compare
|
Ok, this has successfully interop'd with the Nim and Go implementations. That gives me adequate confidence to get this merged and iterate from there. |
lithp
reviewed
Oct 6, 2020
ddht/cli_parser.py
Outdated
| network_parser.add_argument( | ||
|
|
||
| bootnodes_parser_group = network_parser.add_mutually_exclusive_group() | ||
| bootnodes_parser_group.add_argument( | ||
| "--bootnode", | ||
| action=NormalizeAndAppendENR, | ||
| help="IP address to listen on", |
There was a problem hiding this comment.
I think this helpstring is incorrect
lithp
reviewed
Oct 6, 2020
| @@ -106,11 +106,12 @@ async def run(self) -> None: | |||
| self.logger.info("Protocol-Version: %s", self._boot_info.protocol_version.value) | |||
| self.logger.info("DDHT base dir: %s", self._boot_info.base_dir) | |||
| self.logger.info("Starting discovery service...") | |||
| self.logger.info("Listening on %s:%d", listen_on, port) | |||
There was a problem hiding this comment.
why was the port dropped? that seems like it could be useful!
There was a problem hiding this comment.
Not dropped. It was being double reported. listen_on is an Endpoint which contains both IP and port in a single object.
lithp
approved these changes
Oct 6, 2020
pipermerriam
force-pushed
the
piper/v51-spec-update
branch
from
ef8d4a8
to
f3e343e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
ethereum/devp2p#157
The v5.1 spec is now up to date. Our implementations needs to be updated to match it.
How was it fixed?
Updated it.
Cute Animal Picture